Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A retry has been added to the curl that downloads the piper #4315

Merged
merged 9 commits into from
Apr 24, 2023

Conversation

kamil7108
Copy link
Contributor

@kamil7108 kamil7108 commented Apr 3, 2023

Changes

We are using https://github.com/SAP/jenkins-library in our Jenkins pipeline, and we were facing any issue in one of ours long-running application build and there sometimes occurred error "Cannot get piper go binary version: hudson.AbortException". I have managed to minimize this error by adding retry to curl. Using this repository with this change greatly improved the stability of our build.

  • Tests
  • Documentation

@kamil7108 kamil7108 requested a review from a team as a code owner April 3, 2023 10:57
@o-liver
Copy link
Member

o-liver commented Apr 3, 2023

/it-go

@o-liver o-liver requested review from OliverNocon and CCFenner April 3, 2023 14:20
@o-liver
Copy link
Member

o-liver commented Apr 3, 2023

@CCFenner @OliverNocon Could you have a quick look?

@kamil7108
Copy link
Contributor Author

Should I take any action here to have these changes reviewed ?

@kamil7108
Copy link
Contributor Author

@o-liver

Copy link
Member

@o-liver o-liver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@o-liver o-liver enabled auto-merge (squash) April 21, 2023 09:31
@o-liver
Copy link
Member

o-liver commented Apr 24, 2023

/go-it

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@o-liver o-liver merged commit 54d543a into SAP:master Apr 24, 2023
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants