DESS-1710: modified WaitForBuildToFinish function #4270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hello @CCFenner, please review the changes. |
SiarheiKrystseu
commented
Apr 17, 2023
pkg/jenkins/build.go
Outdated
| @@ -20,9 +20,34 @@ type Build interface { | |||
| // WaitForBuildToFinish waits till a build is finished. | |||
| func WaitForBuildToFinish(ctx context.Context, build Build, pollInterval time.Duration) { | |||
There was a problem hiding this comment.
We want to abort build if the server is unavailable in case of network problems. Is it possible to pass error and not change the signature in sapXmakeExecuteBuild? In the next step we want to add some logic to sapXmakeExecuteBuild.
Example:
func WaitForBuildToFinish(ctx context.Context, build Build, pollInterval time.Duration) error {
anilkeshav27
approved these changes
Apr 27, 2023
CCFenner
approved these changes
Apr 28, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
/it-go |
maxatsap
pushed a commit
to maxatsap/jenkins-library
that referenced
this pull request
Jul 23, 2024
* DESS-1710: modified WaitForBuildToFinish function - added exception handling * DESS-1710: fixed parameters in WaitForBuildToFinish * DESS-1710: added error handling in WaitForBuildToFinish * DESS-1710: formatted build.go * DESS-1710: fixed error logging * DESS-1710: fixed Poll retrying * DESS-1710: renamed WaitForBuildToFinish * DESS-1710: refactored WaitForBuildToFinish * DESS-1710: changed maxRetries to 4 attempt * DESS-1710: fixed error handling --------- Co-authored-by: Christopher Fenner <[email protected]> Co-authored-by: Ashly Mathew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR based on https://jira.tools.sap/browse/DESS-1710
There are some issues raised because sapXmakeExecuteBuild tries to download artifacts while the build is still running.
After investigations it seems the problem comes from a wrong connection with the Jenkins which result to a null answer.
The check of the build running seems to return null and this is wrongly considered as build stopped.
Changes
Added exception handling for WaitForBuildToFinish function