Use openerTabId with openNewTabs on Firefox #4518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdesjardins
approved these changes
Oct 30, 2017
kevinji
reviewed
Nov 1, 2017
| urls.forEach((url, i) => { | ||
| chrome.tabs.create({ | ||
| url, | ||
| active: i === focusIndex, | ||
| index: ++currentIndex, |
There was a problem hiding this comment.
Is the index no longer necessary? It's still being used in Chrome's background.entry.js.
There was a problem hiding this comment.
Yes; ideally we would never use index, but:
In Chrome, if you don't specify index, all tabs go to the end, instead of being grouped next to the openerTabId tab (like ctrl/middle-clicking would do).
In Firefox, if you don't specify index, new tabs are grouped next to the openerTabId tab, or at the end if you've disabled insertRelatedAfterCurrent, which is #4230 (either way, the same as ctrl/middle-clicking).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: fixes #4514
Tested in browser:
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0Edit(erikdesjardins): fixes #4230
Edit(mc10): fixes #190