Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No compatibility with FF57 Addons #346

Closed
mikeloeven opened this issue Dec 31, 2017 · 26 comments
Closed

No compatibility with FF57 Addons #346

mikeloeven opened this issue Dec 31, 2017 · 26 comments

Comments

@mikeloeven
Copy link

mikeloeven commented Dec 31, 2017

Several addons i use have been updated for FF57 and can no longer be downloaded or installed due to compatibility errors. I am not sure if this is a false alarm due to waterfox being marked as version 56 or if there really is a compatibility issue. I guess it depends on how much of the code base was combined.

@grahamperrin
Copy link

Please let us have the addons.mozilla.org address of an affected add-on.

Also the result of visiting https://udger.com/resources/online-parser

@mikeloeven
Copy link
Author

Here is the main one https://addons.mozilla.org/en-US/firefox/addon/real-nano-defender/

@defkev
Copy link

defkev commented Dec 31, 2017

If the addon author sets the min-version of his addon to 57 you will need to run 57 to install the addon.

@mikeloeven
Copy link
Author

does waterfox not have the FF57 code base yet ?

@defkev
Copy link

defkev commented Dec 31, 2017

Thankfully not, as this would break every legacy addon, just like FF Quantum 💩

Waterfox will now remain at 56 for the time being...
...

  • Based on Firefox 56.0.2 release

https://www.waterfoxproject.org/blog/waterfox-56.0-release-download

@jdunn0
Copy link

jdunn0 commented Jan 1, 2018

With the release of Firefox 57, Mozilla both removed support for older add-ons and added new APIs for WebExtensions based add-ons to use.
The idea being at that point that the WebExtensions APIs would be good enough that the older add-ons would not be needed.
While that is true for some add-ons, that are many older add-ons that depend on APIs that just don't exist with WebExtensions so you need to use Firefox 56 or Waterfox 56 to use them.
This leads to the unfortunate case where you need an older version of Firefox or a fork like Waterfox to use those older add-ons and the newer version of Firefox to use the add-ons that have migrated to use the new APIs unless that add-on only uses WebExtension APIs that were available in Firefox 56.

In theory, you can have a release of Firefox or Waterfox that supports both the older add-ons and the latest WebExtensions APIs but at the moment, only Mozilla could really do that and they decided against doing that.
The resources and manpower required to support both is something that the smaller development groups for Pale Moon and Waterfox just can't do.
Even just supporting the older add-ons after Mozilla stops supporting them (Around June 2018 when Firefox 52 ESR support ends) will become harder for the developers of Pale Moon and Waterfox.

Hopefully should maintaining support for older add-ons be no longer practical for Pale Moon and Waterfox, there will enough WebExtension APIs available to make it a good option for all add-ons or Mozilla realizes they made a mistake and adds the support for older add-ons back into Firefox.

@grahamperrin
Copy link

Waterfox use of … Quantum code

does waterfox not have the FF57 code base yet ?

Please subscribe to:

– and if we browse other issues, we might find more that relate to Firefox Quantum or Project Quantum code bases.


No compatibility with FF57 Addons

Nano Defender

https://addons.mozilla.org/addon/real-nano-defender/versions/ all apparently work:

with Firefox for Android 57.0 and later, Firefox 57.0 and later

– so it's reasonable to assume that the extension will not work with any Firefox 56.x-based version of Waterfox.

Assumptions aside …

Defocusing from Waterfox

Sometimes, rarely, you'll find that Firefox version requirements expressed at addons.mozilla.org are not entirely representative of an add-on's requirements.

That's true for extensions such as Conex:

Here, with Waterfox:

2018-01-01 12 02 47

Also for Conex there are .xpi releases at GitHub:

No such luck with Nano Defender 13.16. With compatibility checking enabled, nano_defender-13.16-an+fx.xpi can not be installed.

checkCompatibility2 also known as Disable Addon Compatibility Checks (Version 4-56)

With this extension installed: if you're lucky, an apparently incompatible extension will be usable with Firefox 56.0.2 or Waterfox 56.0.1.

An example:

2018-01-01 12 46 14

2018-01-01 12 46 42

2018-01-01 12 47 05

addons.mozilla.org

If ever you successfully perform an installation of an extension that is apparently incompatible with Waterfox;

  • do not expect automated updates from addons.mozilla.org
  • please be prepared to periodically check the add-on's page.

In any case

If you choose to ignore compatibility information: proceed with caution, and at your own risk.

@criztovyl
Copy link

criztovyl commented Jan 1, 2018

Maybe also interesting, from the xpi's manifest.json:

  "applications": {
    "gecko": {
      "strict_min_version": "57.0"
    }
  }

@grahamperrin
Copy link

Yep, as far as I know that strictness (strict_min_version) is what's overridden, at install time, by checkCompatibility2.

@NRG90
Copy link

NRG90 commented Jan 4, 2018

Regarding Nano Defender on Waterfox 56.0.1:

Schermata_2018-01-04_alle_12.30.25.png

download the converted one (from Chrome Version) here:

http://www.mediafire.com/folder/2hzlanm6715l9/Firefox_and_Waterfox_Legacy_addons

@grahamperrin
Copy link

Another add-on that supposedly requires at least Firefox 57.0, truly works with Waterfox 56.0.2:

@sanjayen
Copy link

@NRG90 how did you install Nano Adblocker? I downloaded Nano Defender. How do you keep it updated with the latest version? Thank you for providing the upload site.

@IoanPaleru
Copy link

Hi. The FireX Proxy 5.1.2 add-on from Firefox's add-ons page, doesn't seem to be able to be installed in Waterfox 56.0.3 because there's an error message that says ""FireX Proxy could not be installed because it is not compatible with Waterfox 56.0.3.". I guess that's because WebExtension add-ons that are only compatible with Firefox 57 and newer, aren't compatible with Waterfox 56.0.3, but is there a way to fix that? Thanks.

@grahamperrin
Copy link

grahamperrin commented Feb 2, 2018

… 5.1.2 …

Please follow the link to versions, there's a compatible version.

Alternatively, use about:addons to find and install the extension; the most recent compatible version is automatically chosen for you.

@NRG90
Copy link

NRG90 commented Feb 2, 2018

@sanjayen

Regarding Nano Defender, I used the chrome foxified add-on to convert the Chrome version to the legacy one compatible with waterfox and then I manually check new versions on Chrome web Store

Schermata_2018-02-02_alle_15.38.32.png
https://www.mediafire.com/folder/2hzlanm6715l9/Firefox_and_Waterfox_Legacy_addons

@grahamperrin
Copy link

grahamperrin commented Mar 23, 2018

From above:

If ever you successfully perform an installation of an extension that is apparently incompatible with Waterfox:

  • do not expect automated updates from addons.mozilla.org

From the issue that discusses the possibility of allowing Waterfox 56.1 to receive updates for that type of extension:

AMO doesn't allow installing Waterfox-incompatible extensions.

For completeness, note that with user agent Mozilla/5.0 (X11; FreeBSD amd64; rv:56.0) Gecko/20100101 Firefox/56.0.4 Waterfox/56.0.4 plus a change to compatibility checking, the Download anyway feature of AMO can allow installation of extensions that are partly incompatible with Waterfox 56.0.4.1.

Conex, for example:

2018-03-23 07 55 52

– outdated version 0.2.1 works with Firefox 60.0a1 and later

2018-03-23 07 56 23

2018-03-23 07 58 43

Partial compatibility

In the third shot, there's enabling of an option that we should not (probably must not) expect to work with Waterfox 56.0.4.1.

@nl255
Copy link

nl255 commented Mar 24, 2018

As for Nano Adblocker/Nano Defender, the latest versions work fine if you get them from the Chrome store so they obviously don't need 57+ to work.

@grahamperrin
Copy link

Reddit Enhancement Suite (RES)

RES is another example of an extension that requires Firefox 57 (or greater) for some but not all of its features.

There's the red alert at its AMO page, https://addons.mozilla.org/addon/reddit-enhancement-suite/ – and if you install the most recent version then (with Waterfox 56.1.0) there'll be no automated discovery of updates – but version 5.12.2 of RES is essentially fine with version 56.1.0 of Waterfox.

Known issues

The first set of commits for an API that's not usable with Firefox 56.0.2 was:

That set fixed issues such as these:

  • Shift + Enter on a link will open a tab at the end of the tab bar, rather than next to the current one
  • Opening comments in new tabs in clunky
  • Single Click Opener placing tabs in the wrong location

If those are the type of issue that might bother you, then you should think twice before installing a version of RES that's marked (at AMO) as incompatible with Waterfox.

If (like me) those things are no bother, then you should be fine with 5.12.2.


That's not intended to be a comprehensive list of known issues – there might have been, and probably will be, other commits involving APIs that are not yet usable with Waterfox. It's just a shortlist, an example.

@CyberShadow
Copy link

CyberShadow commented Jun 20, 2018

That set fixed issues such as these:

Here's a patch which reverts that change and allows shift+C etc. to work again:

diff --git a/lib/environment/background/tabs.js b/lib/environment/background/tabs.js
index cb03bda1..845a04ff 100644
--- a/lib/environment/background/tabs.js
+++ b/lib/environment/background/tabs.js
@@ -13,12 +13,11 @@ addListener('openNewTabs', ({ urls, focusIndex }, { id: tabId, index: currentInd
 			});
 		});
 	} else if (process.env.BUILD_TARGET === 'firefox') {
-		// Firefox needs cookieStoreId to open in correct container
 		urls.forEach((url, i) => {
 			chrome.tabs.create({
 				url,
 				active: i === focusIndex,
-				openerTabId: tabId,
+				index: ++currentIndex,
 				cookieStoreId,
 			});
 		});

I don't know what the RES project's stance is on supporting Waterfox, but it should be trivial to adapt it to support the older API version as well as the newer version, if it's available.

Edit: And here's a built .xpi (patch above applied against latest master).

@grahamperrin
Copy link

Waterfox 56.2.3

Installing from addons.mozilla.org (AMO)

From https://www.reddit.com/r/waterfox/comments/9g0tea//e60tgo5/:

… Video DownloadHelper on AMO … 'Add to Firefox' button isn't greyed out anymore. It was greyed out with 56.2.2, …

Video DownloadHelper https://addons.mozilla.org/addon/video-downloadhelper/ 7.3.5 is a good example of a version of an extension that:

  1. "Works with Firefox 57.0a1 and later" and
  2. differs significantly from the most recent compatible legacy version.

Given the constraints of WebExtensions you'll probably find it necessary to use the companion application if you manually install 7.3.5 over 6.3.3. Then if you find 7.3.5 and its companion not working as expected with Waterfox 56.2.3, re: https://www.downloadhelper.net/help you can seek help in the support forum.


Generally, loosely speaking:

  • whilst browsing AMO, with Waterfox 56.2.3 it's easier (than with 56.2.2) to manually install an extension that might be not entirely compatible with Waterfox
  • to check compatibility, prior to installation, it's worth stepping aside from the main page of the extension – click See all versions then pay attention to the "Works with …" line.

Updating

The AMO-oriented update routines in 56.2.3 remain stringent.

For example: Video DownloadHelper should not automatically update from 6.3.3 to 7.3.5.

@grahamperrin
Copy link

From https://www.reddit.com/comments/9g0tea/-/e60osk4/:

… I suppose that somehow Waterfox 56.2.3 has been now marked as equivalent to Firefox 57 (or 58 ?) for AMO addon compatibility

57 but not 58

so that we now … see all 57+ (and maybe 58+ too ?) extensions as compatible even when they are not. …

An unusual, relatively complex example: NoScript

A most recent release of this extension requires Firefox 59.0 or greater:

  1. https://addons.mozilla.org/addon/noscript/
  2. https://addons.mozilla.org/addon/noscript/versions/

At (1) there's a hint, "Fx52?".

At (2) users of Waterfox 56.2.3 will find most of the + Add to Firefox buttons greyed out. Just one of the buttons is green – for version 10.1.6.5, which " Works with Firefox for Android 57.0 and later, Firefox 57.0 and later". The NoScript case is very unusual because this one green button should be ignored and you will not find the appropriate version by continuing to page through the versions that are listed at AMO.

Instead: https://noscript.net/getit#older for more recent version 5.1.8.7 of NoScript, which is intended primarily for use with Firefox ESR 52.

5.1.8.7 is the version that's appropriate for Waterfox 56.2.3. Discussion in the Waterfox area at https://redd.it/9ez5w7 and support for the extension can be sought at https://forums.informaction.com/viewforum.php?f=3.

A pleasantly simple example: Firefox Multi-Account Containers

A blue + Add to Firefox button at https://addons.mozilla.org/addon/multi-account-containers/.

A green (AMO classic) + Add to Firefox button at https://addons.mozilla.org/addon/multi-account-containers/versions/ and here's the detail:

Works with Firefox for Android 57.0 and later, Firefox 57.0 and later

Waterfox 56.2.3 is not entirely compatible with version 6.0.0 of the extension, but the combination is fine.

@skrivskithar
Copy link

Checker plus for gmail

This extension doesn't work after update 21.2.3 (I've been using that version since I moved to Waterfox). I don't understand much about addon development, but I guess it has to do with FF discontinuing legacy addons:

https://addons.mozilla.org/en-US/firefox/addon/checker-plus-gmail/?src=search

If there's no workaround for new versions to work, is there any way to disable it from notifying me about new updates?

@grahamperrin
Copy link

@grahamperrin
Copy link

any way to disable it from notifying me about new updates?

I think not. #349

@skrivskithar
Copy link

thanks for your effort, graham!

@grahamperrin
Copy link

Cookie AutoDelete

From https://www.reddit.com/comments/dahnh0/-/f1te63v/?context=1

Some add-ons say they are not compatible with waterfox, but seem to work perfectly. Latest Cookie Autodelete is one such. …

Re: Cookie-AutoDelete/Cookie-AutoDelete#513 (comment)

… First Party Isolation + CAD doesn't work unless you are on a FF version of 59 or higher. …

Also re: https://addons.mozilla.org/addon/cookie-autodelete/

… can clear localstorage as of version 2.1.0 and Firefox 58+. …

https://addons.mozilla.org/addon/cookie-autodelete/versions/ 2.1.0

  • "… Added: First Party Isolation Support (Firefox 59+, …"; and
  • according to the AMO page it works with Firefox 56.0 and later, Android 57.0 and later

however given what's above, I should assume that 2.1.0 and 2.2.0 are not entirely functional with Waterfox Classic 56.2.14 (assume that features such as clearance of localstorage are non-functional).

Cookie-AutoDelete/Cookie-AutoDelete@0c4a933#diff-2ccaee6c5cfa6c1e0a36166894df97bcL30 the strict_min_version was raised from 56.0 to 59.0 with release 3.0.0 of the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests