Question: Custom hot-key combination?

[stefanos82]

With linkclump on Chrome I am given the option to choose the hot-keys of my choice, but with SnapLinksPlus I have to use mouse's right-click only.

I really like the combination of Shift key + mouse's Left-click.

I have looked at the preferences area and could not find any option like that, unless it's hidden somewhere and cannot see it.

Any suggestion?

Cheers.

[cpriest]

It's not currently possible. I haven't had any time to work on SLP in a long time, it was originally planned and more but life got in the way of future development at the moment. Pull Requests are welcome though, I can review them for release.

[Qwash]

This could fix incompatibility with ScrollAnywhere and other addons 😞

[cpriest]

I'm going to try and get back to SnapLinks soon but would love to get some help with it.

[jacobshare]

+1

[a2sheppy]

Yeah, triggering just on a right-click is troublesome since it can result in being accidentally triggered when using context menus.

[jellypadder]

ehh, this is exactly what i was about to ask about. in an older version i used to be able to hold down my shift button+left mouse button to open links. i find the right click hard to use with the way i have my computer set up.

[rayman89]

Yes please add the options like before to decide what to do by default with the links and its key modifiers.

[m2pt5]

Having it trigger on just right-clicking causes way too many issues, please add the key-to-activate option.

[Markieta]

+1 for Shift+LMB

Using the RMB is tricky on a laptop trackpad.

[cpriest]

This is already available in the beta release version currently on AMO or Chrome.

[m2pt5]

The beta on AMO doesn't seem to be publicly accessible, it just says "0 versions".

[cpriest]

You're right, I don't know why they aren't listed on the versions page now, they were before (and are listed in the developer pages). Here is a link to v3.1.2b2 which may or may not work without my login. I've emailed AMO about the issue to see what's up.

[m2pt5]

That link works, thanks.

[cpriest]

Ah great ok. I'll update the main page. Looks like they are discontinuing 'beta builds' feature and have not quite gotten around to making it work well with automatic signature. For now I'll keep the latest developer build linked directly from the read me page.

[stefanos82]

The latest beta version does not work. i can see the lasso and the highlighted links, but nothing opens as a new tab.

I chose Shift and Left Click and nothing opened.

I then chose Shift and Right Click...nothing yet.

I then chose only Left Click...still nothing.

Am I missing something I should do to make it work?

[m2pt5]

It's probably a conflict with another extension, it works fine for me, the only issue being that the right-click menu pops up when I release the mouse button. (I'm using Shift+Right.)

[stefanos82]

I doubt it.

Here's my extensions' list:

[rayman89]

@cpriest I don't see the option to copy links to clipboard as default behavior when letting go of the lasso in the beta version. Wasn't that paired with the ability to select the key combinations?

[cpriest]

If you turned on developer mode under advanced preferences there is a 'skip all actions' which would cause this.

[cpriest]

@rayman89 That feature hasn't been implemented. I'm not sure the multi-key binding option will be implemented. The original extension had essentially the default action or 'ask me' if holding down another key. At this point, I intend to implement that functionality.

[stefanos82]

@cpriest I haven't done anything other than install it and associate my hotkey combination.

[cpriest]

Hmm, try another key combination. I think Firefox may reserve shift for 'always safe.'

[stefanos82]

I have tried without modifier, with Ctrl + Left-Click, with Middle-key + Left-Click; still the same behavior.

I use Waterfox 56.0.4.1 (64-bit) if that helps a bit.

[m2pt5]

With FF 57, Mozilla added new WebExtensions APIs. Since Waterfox is staying on 56, there may be one or more that this addon uses that it does not have.

Edit: Found this info here: BrowserWorks/Waterfox#346 (comment)

[cpriest]

Ah, this extension is for FireFox and Chrome. If you'd like to submit a pull request for compatibility fixes for other browsers, feel free so long as they don't break the primary browser targets.

I have a well documented Your First Code Contribution document I put together to help you get a local environment setup. I'd be happy to help with any questions.

A good place to start to see where the error may be happening would be the error console (Ctrl + J in Firefox) or the Page Console (F12 in most browsers).

[stefanos82]

OK, I have loaded my VM Windows machine and have upgraded my Firefox to the latest version 59.0.2 (64-bit).

The beta links do not work @cpriest. Is there a link you could share here to manually install it?

[Markieta]

Link doesn't work for me either.

[cpriest]

It would appear that they have completely abandoned the beta program now, all of the beta channel versions are now 'Disabled by Mozilla.'

I guess I will submit the new version for 'release' status, but that will need to go through the review process and may take a week or two, unfortunately.

I guess watch the main page for the 3.1.2.3 version whenever it gets approved.

[FatOrangutan]

I guess I will submit the new version for 'release' status, but that will need to go through the review process and may take a week or two, unfortunately.

Add-ons (even on the release channel) are now published immediately, and reviewed afterwards.

[cpriest]

Ah, didn't catch that. I did notice it was available immediately though which is nice.

…

On 3/29/2018 9:49 PM, FatOrangutan wrote: I guess I will submit the new version for 'release' status, but that will need to go through the review process and may take a week or two, unfortunately. Add-ons (even on the release channel) are now published immediately, and reviewed afterwards. <https://blog.mozilla.org/addons/2017/09/21/review-wait-times-get-shorter/> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#189 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJuW7-Vit7SlvVZRrh6ncl0sRBIHaKDks5tjZ0egaJpZM4O1u41>.

[stefanos82]

Finally, I have upgraded to Waterfox 56.1.0 (64-bit) and installed the latest SnapLinksPlus and everything works as expected.

Excellent job @cpriest 👍

[Markieta]

Working fine on Firefox Quantum 59.0.2 (64-bit). Thank you @cpriest!