Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Click Opener placing tabs in the wrong location #4230

Closed
goofydylan8 opened this issue May 10, 2017 · 1 comment · Fixed by #4518
Closed

Single Click Opener placing tabs in the wrong location #4230

goofydylan8 opened this issue May 10, 2017 · 1 comment · Fixed by #4518

Comments

@goofydylan8
Copy link

What's the problem?
"Single Click Opener" now opens the link and comments in two tabs next to my current tab, instead of at the end. I have browser.tabs.insertRelatedAfterCurrent to false which normally results in any new tab opening at the far right of any open tabs.

Are there any related posts in https://github.com/honestbleeps/Reddit-Enhancement-Suite/issues or /r/RESissues?

https://www.reddit.com/r/RESissues/comments/69r274/res_560_lc_lc_doesnt_respect_tab_opening_location/
https://www.reddit.com/r/Enhancement/comments/69x8nc/new_behaviour_for_single_click_opener/
https://www.reddit.com/r/RESissues/comments/6a9hmr/single_click_opener_putting_tabs_in_the_wrong_spot/

What other browser extensions are installed?
Add-On Compatibility Reporter
Bulk Media Downloader
Checker Plus for Gmail
F.B. Purity
Forecastfox (fix version)
FrankerFaceZ
Google Search link fix
Greasemonkey
Image Search for Google
NativeShot
Nightly Tester Tools
OpenDownload2
Restart
S3.Google Translator
Stylish
Tab Mix Plus
uBlock Origin
Undo Close Tab
Youtube Plus

@erikdesjardins
Copy link
Collaborator

The crux of the issue is that tabs opened by WebExtensions don't obey the insertRelatedAfterCurrent preference. So to keep the default behaviour (opening tabs next to the current one), we explicitly open them next to the current one. When Firefox supports openerTabId then this will probably work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants