Use openerTabId with openNewTabs on Firefox (#4518)

* Use openerTabId with openNewTabs on Firefox * require firefox 57
honestbleeps · Nov 13, 2017 · d840ad1 · d840ad1
1 parent bde40b7
commit d840ad1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/firefox/background.entry.js b/firefox/background.entry.js
@@ -28,13 +28,13 @@ addListener('download', ({ url, filename }) => {
 	chrome.downloads.download({ url, filename });
 });
 
-// Firefox doesn't support openerTabId, and needs cookieStoreId to open in correct container
-addListener('openNewTabs', ({ urls, focusIndex }, { index: currentIndex, cookieStoreId }) => {
+// Firefox needs cookieStoreId to open in correct container
+addListener('openNewTabs', ({ urls, focusIndex }, { id: tabId, cookieStoreId }) => {
 	urls.forEach((url, i) => {
 		chrome.tabs.create({
 			url,
 			active: i === focusIndex,
-			index: ++currentIndex,
+			openerTabId: tabId,
 			cookieStoreId,
 		});
 	});

diff --git a/firefox/beta/manifest.json b/firefox/beta/manifest.json
@@ -8,7 +8,7 @@
 	"applications": {
 		"gecko": {
 			"id": "jid1-xUfzOsOFlzSOXg@jetpack",
-			"strict_min_version": "55.0"
+			"strict_min_version": "57.0"
 		}
 	},
 	"icons": {

diff --git a/firefox/manifest.json b/firefox/manifest.json
@@ -8,7 +8,7 @@
 	"applications": {
 		"gecko": {
 			"id": "jid1-xUfzOsOFlzSOXg@jetpack",
-			"strict_min_version": "55.0"
+			"strict_min_version": "57.0"
 		}
 	},
 	"icons": {