Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to avoid non-pypi packages if possible #7069

Closed
32 tasks done
andrey-git opened this issue Apr 12, 2017 · 40 comments · Fixed by #7430, #7436 or #15490
Closed
32 tasks done

Try to avoid non-pypi packages if possible #7069

andrey-git opened this issue Apr 12, 2017 · 40 comments · Fixed by #7430, #7436 or #15490

Comments

@andrey-git
Copy link
Contributor

andrey-git commented Apr 12, 2017

requirements_all.txt has 31 packages defined from github.
When running script/setup each such package needs to be re-downloaded.
Lets try to convert to pypi whenever possible.

@balloob
Copy link
Member

balloob commented May 2, 2017

This is a great initiative!

@andrey-git
Copy link
Contributor Author

Spotipy is waiting for spotipy-dev/spotipy#182

@andrey-git
Copy link
Contributor Author

andrey-git commented May 2, 2017

@jabesq could you comment on the difference between your fork of netatmo-api-python used in HA and the upstream version?
If there is no intent to unite them, could you

  • Enable issues on your fork
  • Create a pypi version of your netatmo-api-python

@andrey-git
Copy link
Contributor Author

@jabesq Same question for pybotvac

@andrey-git
Copy link
Contributor Author

@pschmitt could you publish your fork of pymailgun to pypi?
Seems @cogniteev didn't respond to any of your PRs.
Also might make sense to enable Issues on your fork.

@andrey-git
Copy link
Contributor Author

@robbiet480 what's in your version of pygtfsthat is missing from the upstream version?
The upstream seems alive - could you propose your changes there?

@andrey-git
Copy link
Contributor Author

@tfriedel Thomas, if your version of python-lightify is incompatible with @aneumeier 's could you publish your version to pypi?

@jeradM
Copy link
Member

jeradM commented Feb 11, 2018

Created PR #12290 for sabnzbd

@balloobbot
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

@andrey-git
Copy link
Contributor Author

Lets keep this open

@balloob
Copy link
Member

balloob commented May 29, 2018

There are 10 packages left, it's been a year. I suggest we do a final check if packages have been moved to PyPi. Migrate the platforms to use PyPi based requirements if they have, otherwise disable the requirement.

A year is a long time, if it hasn't happened now, it won't happen.

@andrey-git
Copy link
Contributor Author

Netatmo got a pypi package in #14824

@dshokouhi
Copy link
Member

@andrey-git I have tested the latest version of pybotvac 0.0.6 (home assistant is using 0.0.5)

https://github.com/jabesq/pybotvac/releases/tag/v0.0.6

and have also tested the proposed change to get the D7 working as I am using it now.

stianaske/pybotvac#14
#13950

I saw you commented on the original repo to get a pypi package so hopefully we can get it done soon. If there is anything else I can do to help out here let me know :)

@andrey-git
Copy link
Contributor Author

Thanks Daniel! I asked stianaske/pybotvac#13 to create a pypi package.

andrey-git added a commit that referenced this issue Jul 2, 2018
## Description:

Switch to own packaged version of pylgnetcast

Request to make a pypi package didn't get any response: wokar/pylgnetcast#1

**Related issue (if applicable):** #7069
@andrey-git
Copy link
Contributor Author

Edimax was fixed in #12873

awarecan pushed a commit to awarecan/home-assistant that referenced this issue Jul 16, 2018
## Description:

Switch to own packaged version of pylgnetcast

Request to make a pypi package didn't get any response: wokar/pylgnetcast#1

**Related issue (if applicable):** home-assistant#7069
@ghost ghost assigned andrey-git Jul 16, 2018
@ghost ghost added the in progress label Jul 16, 2018
@ghost ghost removed the in progress label Jul 18, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.