-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.1 #62
Comments
I'm a little confused by all this. The latest version of HA is tagged to a recent commit. There is a PR in the works to fix a source selection issue, at which point I'll aim the HA requirement line at the new commit, tagged commit (preferable to tagging a commit) or pypi release (best case). |
Ok guess i was a little over my head. Late on i saw that push request contained link to the latest branch. Sorry - not a tech guy. But the files i've found in my ha dir didn't include the fixes for the import statements. So i had to add them manually. If possible if we continue on the HA board? https://community.home-assistant.io/t/onkyo-broken-in-0-42/15273/2 |
@miracle2k could you release a new pypi version? |
A new version was pushed to PyPI. |
With all the latest pull requests merged - onkyo-eiscp is working great.
The only problem there was a pull request in Home Assistant (quite popular home automation software) to use this library instead of the forked one.
So instead of a new code - we are getting the release 1.0 which contains some bugs especially with python3 compatability.
Below are the relevant lines from home-assistant.
miracle2k, is there a possiility you will put up a 1.1 Release so all the fixed bugs will be gone?
-REQUIREMENTS = ['https://github.com/danieljkemp/onkyo-eiscp/archive/'
+REQUIREMENTS = ['https://github.com/miracle2k/onkyo-eiscp/archive/py3.zip#onkyo-eiscp==1.0']
+#'python3.zip#onkyo-eiscp==0.9.2']
The text was updated successfully, but these errors were encountered: