Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1 #62

Closed
moskovskiy82 opened this issue Apr 10, 2017 · 4 comments
Closed

Release 1.1 #62

moskovskiy82 opened this issue Apr 10, 2017 · 4 comments

Comments

@moskovskiy82
Copy link

moskovskiy82 commented Apr 10, 2017

With all the latest pull requests merged - onkyo-eiscp is working great.
The only problem there was a pull request in Home Assistant (quite popular home automation software) to use this library instead of the forked one.

So instead of a new code - we are getting the release 1.0 which contains some bugs especially with python3 compatability.
Below are the relevant lines from home-assistant.

miracle2k, is there a possiility you will put up a 1.1 Release so all the fixed bugs will be gone?

-REQUIREMENTS = ['https://github.com/danieljkemp/onkyo-eiscp/archive/'

  •            'python3.zip#onkyo-eiscp==0.9.2']
    

+REQUIREMENTS = ['https://github.com/miracle2k/onkyo-eiscp/archive/py3.zip#onkyo-eiscp==1.0']
+#'python3.zip#onkyo-eiscp==0.9.2']

@danieljkemp
Copy link

I'm a little confused by all this.

https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/media_player/onkyo.py#L17-L19

The latest version of HA is tagged to a recent commit. There is a PR in the works to fix a source selection issue, at which point I'll aim the HA requirement line at the new commit, tagged commit (preferable to tagging a commit) or pypi release (best case).

@moskovskiy82
Copy link
Author

moskovskiy82 commented Apr 11, 2017

Ok guess i was a little over my head. Late on i saw that push request contained link to the latest branch. Sorry - not a tech guy. But the files i've found in my ha dir didn't include the fixes for the import statements. So i had to add them manually. If possible if we continue on the HA board? https://community.home-assistant.io/t/onkyo-broken-in-0-42/15273/2
As currently for me the whole setup is broken and not sure if it's overall or only my problem

@andrey-git
Copy link

@miracle2k could you release a new pypi version?
There were plenty of changes since Aug 2016.
It would also allow py3 code to depend on a cut pypi version instead of a brunch.
home-assistant/core#7069

@miracle2k
Copy link
Owner

A new version was pushed to PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants