Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up requirements #7391

Merged
merged 1 commit into from
May 2, 2017
Merged

Clean up requirements #7391

merged 1 commit into from
May 2, 2017

Conversation

andrey-git
Copy link
Contributor

Description:

Clean up requirements

  • Switch from http to https
  • Switch to pypi version of pythinkingcleaner

Related issue (if applicable): #7069

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@mention-bot
Copy link

@andrey-git, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @Teagan42 and @rmkraus to be potential reviewers.

@@ -12,9 +12,7 @@

_LOGGER = logging.getLogger(__name__)

REQUIREMENTS = ['https://github.com/TheRealLink/pythinkingcleaner'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a risky upgrade. We should ask @TheRealLink if this is possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff between versions is just pypi setup: https://github.com/TheRealLink/pythinkingcleaner/commits/master

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐬

@balloob balloob merged commit 570c554 into home-assistant:dev May 2, 2017
@andrey-git andrey-git deleted the req branch May 2, 2017 16:26
@balloob balloob mentioned this pull request May 5, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants