Fix Edimax new firmware auth error and move to pyedimax fork #12873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @andreipop2005, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
homeassistant
added
cla-needed
platform: switch.edimax
small-pr
MartinHjelmare
requested changes
Mar 3, 2018
| @@ -13,8 +13,8 @@ | |||
| CONF_HOST, CONF_NAME, CONF_PASSWORD, CONF_USERNAME) | |||
| import homeassistant.helpers.config_validation as cv | |||
|
|
|||
| REQUIREMENTS = ['https://github.com/rkabadi/pyedimax/archive/' | |||
| '365301ce3ff26129a7910c501ead09ea625f3700.zip#pyedimax==0.1'] | |||
| REQUIREMENTS = ['https://github.com/andreipop2005/pyedimax/archive/' | |||
There was a problem hiding this comment.
Home assistant requirements need to be published to pypi since a while.
There was a problem hiding this comment.
Original package maintainer did not respond to comments/messages/etc since August last year, although I really tried to make my fix pulled, but no response.
I will publish the change to pypi.
andrey-git
approved these changes
Mar 3, 2018
|
Did you run |
|
All should be ok now. |
MartinHjelmare
requested changes
Mar 4, 2018
requirements_test_all.txt
Outdated
| @@ -129,6 +129,9 @@ py-canary==0.4.1 | |||
| # homeassistant.components.zwave | |||
| pydispatcher==2.0.5 | |||
|
|
|||
| # homeassistant.components.switch.edimax | |||
| pyedimax==0.1 | |||
There was a problem hiding this comment.
This should not be added to this file as there are no tests for this platform.
script/gen_requirements_all.py
Outdated
| @@ -66,6 +66,7 @@ | |||
| 'pushbullet.py', | |||
| 'py-canary', | |||
| 'pydispatcher', | |||
| 'pyedimax', | |||
|
Done |
MartinHjelmare
changed the title
Merged
32 tasks
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This fixes the authentication error for Edimax switches. I solved it a while ago, the fix is trivial, but the original repository is no longer maintained. I forked it and fixed the issue, then changed the requirements for home assistant.
Related issue (if applicable): fixes #9339
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass