Optimization and refinements done for Home-Assistant #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return raw response to let consuming code decide what to do to the data.
Signed-off-by: Hugo DUPRAS <[email protected]>
…aning service (cherry picked from commit 75bbb28)
… mode & navigationMode to startCleaning (cherry picked from commit dedf9c7)
A few changes before merging into main branch: - Create UnsupportedDevice exception class, to simplify catching exception in user code. - Create read-only properties for available_services and service_version. - Check that service version is supported once (in __init__), to avoid code duplication. - Renamed a few variables for PEP 8 compliance. - Bumped version (cherry picked from commit 43d9f41)
Fix header format (cherry picked from commit 0fc58bf)
|
Looks good! Thanks! |
|
@stianaske please upload to pypi if possible. I think it should be as easy as after you create pypi user. |
32 tasks
|
@andrey-git version 0.0.7 has been uploaded to pypi. Appologies for the slow response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some optimization done for Home-Assistant
Question: Is there a plan to send this API on Pypi so it will be easier to deploy and manage ?