Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi-issuer functionality to PKI #1910

Merged
merged 16 commits into from
Jun 20, 2023

Conversation

vinay-gopalan
Copy link
Contributor

This PR adds the necessary resources and data sources to support the multi-issuer flow in the PKI engine. This PR also contains the relevant documentation and tests for the resources and datasources added.

vinay-gopalan and others added 13 commits May 4, 2023 14:22
…rraform-provider-vault into VAULT-5960/pki-multi-issuer
* secret/pki: add issuer_ref field

* add test cases

* add docs

* simplify test checks
)

* use context methods and consts

* use loops for fields in create method

* use loops for update and read; handle special cases

* rearrange code for consistency and add comments for posterity

* add comment about adding new fields

* fix comment

* remove use of Exists field and function
* pki/secrets: add allowed_uri_sans_template field to role resource

* add allow_wildcard_certificates field

* fix name of new field
@vinay-gopalan vinay-gopalan requested review from a team and fairclothjm June 20, 2023 15:46
Copy link
Contributor

@raymonstah raymonstah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants