Add allowed_uri_sans_template option for vault_pki_secret_backend_role #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
harsimranmaan
force-pushed
the
allowed_uri_sans_template
branch
from
c3f734a to
38e59c7
Compare
harsimranmaan
changed the title
harsimranmaan
force-pushed
the
allowed_uri_sans_template
branch
from
38e59c7 to
642ed7d
Compare
This PR requires hashicorp/vault#10249 to be merged. One test is right failing until the feature is released in vault. The following test shall pass when teh feature lands on vault ```bash TESTARGS="-run TestPkiSecretBackendRole" make testacc ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test $(go list ./...) -v -run TestPkiSecretBackendRole -timeout 20m ? github.com/hashicorp/terraform-provider-vault [no test files] ? github.com/hashicorp/terraform-provider-vault/cmd/coverage [no test files] ? github.com/hashicorp/terraform-provider-vault/cmd/generate [no test files] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/codegen (cached) [no tests to run] ? github.com/hashicorp/terraform-provider-vault/generated [no test files] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation (cached) [no tests to run] ? github.com/hashicorp/terraform-provider-vault/helper [no test files] ? github.com/hashicorp/terraform-provider-vault/schema [no test files] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/util (cached) [no tests to run] === RUN TestPkiSecretBackendRole_basic resource_pki_secret_backend_role_test.go:16: Step 2/2 error: Check failed: Check 19/47 error: vault_pki_secret_backend_role.test: Attribute 'allowed_uri_sans_template' expected "true", got "false" --- FAIL: TestPkiSecretBackendRole_basic (4.00s) FAIL FAIL github.com/hashicorp/terraform-provider-vault/vault 4.255s FAIL make: *** [testacc] Error 1 ```
harsimranmaan
force-pushed
the
allowed_uri_sans_template
branch
from
642ed7d to
9c70ba5
Compare
|
@benashz can this be merged to ship with the next provider release for feature parity? |
|
closed by #1910 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires hashicorp/vault#10249 to be merged.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG:
Output from acceptance testing: