Add allowed_uri_sans_template #10249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following! This is a feature we really want to use, I spent the morning trying to make something work and then saw this PR 👍 |
|
Exactly what I have been looking for. @pbohman Do you want to rebase the PR? |
harsimranmaan
added a commit
to harsimranmaan/terraform-provider-vault
that referenced
this pull request
Oct 1, 2021
This PR requires hashicorp/vault#10249 to be merged. One test is right failing until the feature is released in vault. The following test shall pass when teh feature lands on vault ```bash TESTARGS="-run TestPkiSecretBackendRole" make testacc ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test $(go list ./...) -v -run TestPkiSecretBackendRole -timeout 20m ? github.com/hashicorp/terraform-provider-vault [no test files] ? github.com/hashicorp/terraform-provider-vault/cmd/coverage [no test files] ? github.com/hashicorp/terraform-provider-vault/cmd/generate [no test files] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/codegen (cached) [no tests to run] ? github.com/hashicorp/terraform-provider-vault/generated [no test files] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation (cached) [no tests to run] ? github.com/hashicorp/terraform-provider-vault/helper [no test files] ? github.com/hashicorp/terraform-provider-vault/schema [no test files] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/util (cached) [no tests to run] === RUN TestPkiSecretBackendRole_basic resource_pki_secret_backend_role_test.go:16: Step 2/2 error: Check failed: Check 19/47 error: vault_pki_secret_backend_role.test: Attribute 'allowed_uri_sans_template' expected "true", got "false" --- FAIL: TestPkiSecretBackendRole_basic (4.00s) FAIL FAIL github.com/hashicorp/terraform-provider-vault/vault 4.255s FAIL make: *** [testacc] Error 1 ```
harsimranmaan
added a commit
to harsimranmaan/terraform-provider-vault
that referenced
this pull request
Oct 1, 2021
This PR requires hashicorp/vault#10249 to be merged. One test is right failing until the feature is released in vault. The following test shall pass when teh feature lands on vault ```bash TESTARGS="-run TestPkiSecretBackendRole" make testacc ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test $(go list ./...) -v -run TestPkiSecretBackendRole -timeout 20m ? github.com/hashicorp/terraform-provider-vault [no test files] ? github.com/hashicorp/terraform-provider-vault/cmd/coverage [no test files] ? github.com/hashicorp/terraform-provider-vault/cmd/generate [no test files] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/codegen (cached) [no tests to run] ? github.com/hashicorp/terraform-provider-vault/generated [no test files] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation (cached) [no tests to run] ? github.com/hashicorp/terraform-provider-vault/helper [no test files] ? github.com/hashicorp/terraform-provider-vault/schema [no test files] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/util (cached) [no tests to run] === RUN TestPkiSecretBackendRole_basic resource_pki_secret_backend_role_test.go:16: Step 2/2 error: Check failed: Check 19/47 error: vault_pki_secret_backend_role.test: Attribute 'allowed_uri_sans_template' expected "true", got "false" --- FAIL: TestPkiSecretBackendRole_basic (4.00s) FAIL FAIL github.com/hashicorp/terraform-provider-vault/vault 4.255s FAIL make: *** [testacc] Error 1 ```
|
@pbohman hey Pete, thanks for your contribution. Do you want to rebase the PR and resolve the merge conflict? |
Enables identity templating for the allowed_uri_sans field in PKI cert roles. Implemented as suggested in hashicorp#8509
pbohman
force-pushed
the
template_uri_sans
branch
from
0131f8b to
9ee3d83
Compare
harsimranmaan
added a commit
to harsimranmaan/terraform-provider-vault
that referenced
this pull request
Oct 26, 2021
This PR requires hashicorp/vault#10249 to be merged. One test is right failing until the feature is released in vault. The following test shall pass when teh feature lands on vault ```bash TESTARGS="-run TestPkiSecretBackendRole" make testacc ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test $(go list ./...) -v -run TestPkiSecretBackendRole -timeout 20m ? github.com/hashicorp/terraform-provider-vault [no test files] ? github.com/hashicorp/terraform-provider-vault/cmd/coverage [no test files] ? github.com/hashicorp/terraform-provider-vault/cmd/generate [no test files] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/codegen (cached) [no tests to run] ? github.com/hashicorp/terraform-provider-vault/generated [no test files] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation (cached) [no tests to run] ? github.com/hashicorp/terraform-provider-vault/helper [no test files] ? github.com/hashicorp/terraform-provider-vault/schema [no test files] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/util (cached) [no tests to run] === RUN TestPkiSecretBackendRole_basic resource_pki_secret_backend_role_test.go:16: Step 2/2 error: Check failed: Check 19/47 error: vault_pki_secret_backend_role.test: Attribute 'allowed_uri_sans_template' expected "true", got "false" --- FAIL: TestPkiSecretBackendRole_basic (4.00s) FAIL FAIL github.com/hashicorp/terraform-provider-vault/vault 4.255s FAIL make: *** [testacc] Error 1 ```
|
@hsimon-hashicorp Any chance that this could be prioritized? |
|
@harsimranmaan Thanks for bubbling this up! I'll get a reviewer as soon as I can. Thanks! |
schultz-is
suggested changes
Dec 14, 2021
There was a problem hiding this comment.
Howdy @pbohman, thanks for the contribution! This looks functionally great. In order to get this merged in, can we get a changelog entry (changelog/10249.txt)?
Also, if we can get a documentation update PR (a new PR is fine), if it's needed, that'd be great :) |
|
@schultz-is, @hsimon-hashicorp, @harsimranmaan, thanks for the review and pushing this forward. The changelog and docs have been updated. |
schultz-is
approved these changes
Dec 15, 2021
|
Thanks for contributing this, @pbohman! |
harsimranmaan
added a commit
to harsimranmaan/terraform-provider-vault
that referenced
this pull request
Dec 21, 2021
This PR requires hashicorp/vault#10249 to be merged. One test is right failing until the feature is released in vault. The following test shall pass when teh feature lands on vault ```bash TESTARGS="-run TestPkiSecretBackendRole" make testacc ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test $(go list ./...) -v -run TestPkiSecretBackendRole -timeout 20m ? github.com/hashicorp/terraform-provider-vault [no test files] ? github.com/hashicorp/terraform-provider-vault/cmd/coverage [no test files] ? github.com/hashicorp/terraform-provider-vault/cmd/generate [no test files] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/codegen (cached) [no tests to run] ? github.com/hashicorp/terraform-provider-vault/generated [no test files] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template (cached) [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation (cached) [no tests to run] ? github.com/hashicorp/terraform-provider-vault/helper [no test files] ? github.com/hashicorp/terraform-provider-vault/schema [no test files] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-vault/util (cached) [no tests to run] === RUN TestPkiSecretBackendRole_basic resource_pki_secret_backend_role_test.go:16: Step 2/2 error: Check failed: Check 19/47 error: vault_pki_secret_backend_role.test: Attribute 'allowed_uri_sans_template' expected "true", got "false" --- FAIL: TestPkiSecretBackendRole_basic (4.00s) FAIL FAIL github.com/hashicorp/terraform-provider-vault/vault 4.255s FAIL make: *** [testacc] Error 1 ```
heppu
pushed a commit
to heppu/vault
that referenced
this pull request
Jan 13, 2022
* Add allowed_uri_sans_template Enables identity templating for the allowed_uri_sans field in PKI cert roles. Implemented as suggested in hashicorp#8509 * changelog++ * Update docs with URI SAN templating
|
Thanks for adding this ❤️ We just ran into this issue at @monzo trying to template spiffe:// SANs. Any chance we could get this released as a new tag? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables identity templating for the allowed_uri_sans field in PKI cert roles.
Implemented as suggested in #8509