pki/secrets: add missing fields to role resource #1858
Conversation
| @@ -28,48 +28,49 @@ var ( | |||
| // Any new fields should probably not be added to these lists. Instead handle | |||
| // them separately within a provider.IsAPISupported guard | |||
| var pkiSecretFields = []string{ | |||
There was a problem hiding this comment.
These were just sorted. Nothing has been added/removed
| consts.FieldUseCSRSans, | ||
| consts.FieldAllowLocalhost, | ||
| consts.FieldAllowSubdomains, | ||
| consts.FieldAllowedURISansTemplate, |
There was a problem hiding this comment.
This is the new field allowed_uri_sans_template. There were no other additions/deletions. All other fields were sorted
| consts.FieldAllowedURISansTemplate: { | ||
| Type: schema.TypeBool, | ||
| Optional: true, | ||
| Computed: true, |
There was a problem hiding this comment.
The default value from the API is "false" so we are safe to set this boolean as "Computed"
fairclothjm
changed the title
| consts.FieldAllowLocalhost, | ||
| consts.FieldAllowSubdomains, | ||
| consts.FieldAllowedURISansTemplate, | ||
| consts.FieldAllowedWildcardCertificates, |
There was a problem hiding this comment.
This is the other new field allow_wildcard_certificates
| Required: false, | ||
| Optional: true, | ||
| Description: "Flag to allow wildcard certificates", | ||
| Default: true, |
There was a problem hiding this comment.
The default value returned by the Vault API is "true" so we must set the default here.
|
@fairclothjm would y'all be amenable to cherry picking this change to We heavily rely on the Vault Terraform Provider, and are looking to use it to configure templated PKI mount roles for clients to get SPIFFE like identity certs. w/ their identity in the URI SANs field. I believe that we'd need the |
|
@ianferguson This is planned for the next TFVP release. Targeting within the next few weeks. |
|
@fairclothjm sounds great, really appreciate the quick reply |
This PR adds the following fields to the
vault_pki_secret_backend_roleresource: