pki/secrets: Update Role resource to use more up-to-date patterns #1848
Conversation
| @@ -22,56 +25,103 @@ var ( | |||
| pkiSecretBackendRoleNameFromPathRegex = regexp.MustCompile("^.+/roles/(.+)$") | |||
| ) | |||
|
|
|||
| // Any new fields should probably not be added to these maps. Instead handle | |||
| // them separately within a provider.IsAPISupported guard | |||
There was a problem hiding this comment.
Wondering what people think of this suggestion?
In theory we should be able to add new fields to these maps as long as we used the provider.IsAPISupported guard inside the for loops. I was thinking that this suggestion I am making above would be simpler though. 🤔
There was a problem hiding this comment.
This is just because there's lists of the fields that get looped through because of the large amount of them? The note makes sense to me, as to not add new fields to the existing lists since they won't be supported by the same API version as the others being looped through.
You called them "maps" in the comments, did you mean just "slices" or "lists"?
There was a problem hiding this comment.
woops... yep slices!
There was a problem hiding this comment.
I like this note! Should help incoming developers understand the code style and patterns 👍🏼
| ReadContext: ReadContextWrapper(pkiSecretBackendRoleRead), | ||
| UpdateContext: pkiSecretBackendRoleUpdate, | ||
| DeleteContext: pkiSecretBackendRoleDelete, | ||
| Exists: pkiSecretBackendRoleExists, |
There was a problem hiding this comment.
I think we can remove this; part of an older code pattern
| @@ -22,56 +25,103 @@ var ( | |||
| pkiSecretBackendRoleNameFromPathRegex = regexp.MustCompile("^.+/roles/(.+)$") | |||
| ) | |||
|
|
|||
| // Any new fields should probably not be added to these maps. Instead handle | |||
| // them separately within a provider.IsAPISupported guard | |||
There was a problem hiding this comment.
I like this note! Should help incoming developers understand the code style and patterns 👍🏼
|
|
||
| // handle TypeBool | ||
| for _, k := range pkiSecretBooleanFields { | ||
| // use d.Get for booleans |
There was a problem hiding this comment.
Nice! Kudos for the extra doc strings 😎
Use constants, context methods and loops where appropriate in order to deduplicate code patterns.
This PR intentionally does not make any modifications to test files. The hope is that these changes do not change any of the existing behavior for this resource.