Add multi-issuer support to PKI Intermediate resources #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…termediate-resources
vinay-gopalan
changed the title
vinay-gopalan
commented
May 17, 2023
| Check: resource.ComposeTestCheckFunc( | ||
| resource.TestCheckResourceAttr(resourceName, "backend", intermediatePath), | ||
| resource.TestCheckResourceAttr(resourceName, "common_name", "cert.test.my.domain"), | ||
| testValidateCSR(resourceName), | ||
| ), | ||
| }, | ||
| { | ||
| SkipFunc: func() (bool, error) { |
There was a problem hiding this comment.
This test will be pulled into its own test in a follow-up PR since Root Issuers need to be imported into the Intermediate mount for the full workflow. It will be better to isolate the test steps into their own test when the import bit is added in. Going to leave this in for this PR to demonstrate that the field is working as expected
An additional test will also be added in for vault/resource_pki_secret_backend_cert_test.go for the same use-case.
raymonstah
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds multi-issuer support to the PKI intermediate and sign resources.
Main changes:
issuer_refissuer_refAdditional changes:
Tests and documentation included