-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-issuer support to PKI Intermediate resources #1865
Add multi-issuer support to PKI Intermediate resources #1865
Conversation
…termediate-resources
Check: resource.ComposeTestCheckFunc( | ||
resource.TestCheckResourceAttr(resourceName, "backend", intermediatePath), | ||
resource.TestCheckResourceAttr(resourceName, "common_name", "cert.test.my.domain"), | ||
testValidateCSR(resourceName), | ||
), | ||
}, | ||
{ | ||
SkipFunc: func() (bool, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test will be pulled into its own test in a follow-up PR since Root Issuers need to be imported into the Intermediate mount for the full workflow. It will be better to isolate the test steps into their own test when the import bit is added in. Going to leave this in for this PR to demonstrate that the field is working as expected
An additional test will also be added in for vault/resource_pki_secret_backend_cert_test.go
for the same use-case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds multi-issuer support to the PKI intermediate and sign resources.
Main changes:
issuer_ref
issuer_ref
Additional changes:
Tests and documentation included