New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Cloud Storage Transfer resource #2181

Closed

akramhussein wants to merge 349 commits into hashicorp:master from akramhussein:storage_transfer

Contributor

akramhussein commented Oct 7, 2018

This is a full implementation of the Google Cloud Storage Transfer resource that addresses #1286 issue.

Full documentation for Terraform docs is also included that is primary sourced from official Google Docs.

This supersedes a previous PR #2164 that was incomplete.

I've not had a chance to write unit tests but believe it would be good to get your feedback at this stage on anything that I should change/improve. I have tested it significantly manually.

ghost added the size/xxl label

akramhussein mentioned this pull request

Support for gcp bucket transfers #1286

Closed

Contributor Author

akramhussein commented Oct 8, 2018

I believe this PR could be improved with:

Unit tests
Adding a data_source to get the Storage Transfer Service Account which shouldn't be too hard.

Contributor Author

akramhussein commented Oct 8, 2018

Added datasource to get the project's service account
Added datasource test
Added resource basic test

modular-magician and others added 26 commits

October 29, 2018 15:42


          use correct fields for bigtable test (hashicorp#2353)

e725b02

<!-- This change is generated by MagicModules. -->
/cc @danawillow


          Increase redis timeouts (hashicorp#2351)

955d21c

<!-- This change is generated by MagicModules. -->
/cc @danawillow


          Update composer timeouts (hashicorp#2354)

<!-- This change is generated by MagicModules. -->
/cc @danawillow


          add retries on create for container cluster (hashicorp#2352)

94f2d43

<!-- This change is generated by MagicModules. -->
/cc @danawillow


          Merge pull request hashicorp#2319 from modular-magician/codegen-pr-609

7c56388

Fix ci tests


          Remove name_prefix from container node pool

9a79794


          Remove duplicate storage_object_access_control test. (hashicorp#2349)

6124c20

blocking GoogleCloudPlatform/magic-modules#630

This resource won't be tested between this merging and the MM pr merging


          Generate DefaultObjectAccessControl in Terraform (hashicorp#2358)

c3764b2

<!-- This change is generated by MagicModules. -->
/cc @rileykarson


          Remove obsolete beta files. (hashicorp#2355)

fc4572d

Remove the files we skip now with GoogleCloudPlatform/magic-modules#631


          Merge pull request hashicorp#2356 from modular-magician/codegen-pr-638

71c849e

Remove name_prefix from container node pool


          Remove beta resources to fix build

0c7bc33


          Remove beta generated resource maps from GA provider. (hashicorp#2350)

081847c

<!-- This change is generated by MagicModules. -->
/cc @rileykarson


          Make google_project_iam_policy authoritative. (hashicorp#2315)

251a433

<!-- This change is generated by MagicModules. -->
/cc @rileykarson


          Remove files that aren't managed by magic-modules or explicitly exclu…

ce0fb82

…ded. (hashicorp#2368)


          Update CHANGELOG.md

3e2b08b


          Update CHANGELOG.md

997fa98


          Update provider docs for 2.0.0 (hashicorp#2360)

cb688f5

<!-- This change is generated by MagicModules. -->
/cc @rileykarson


          Remove bad docs (hashicorp#2371)

3735e1c

<!-- This change is generated by MagicModules. -->
/cc @rileykarson


          Remove all of the deprecated fields from the website docs (hashicorp#…

a317b4a

…2362)


          Fix typo in resource name (hashicorp#2365)

cfdfd63


          regional and private clusters are in GA now (hashicorp#2364)

adaf210

<!-- This change is generated by MagicModules. -->
/cc @danawillow 

Fixes hashicorp#2286


          Update CHANGELOG.md

5d7c18f


          add diffsuppress for iam custom role stage. fixes TPG hashicorp#1801 (h…

77ba7d0

…ashicorp#2370)


          Update CHANGELOG.md

26bb23b


          Update igm and rigm docs (hashicorp#2377)


          Add missing resources and datasources to sidebar. (hashicorp#2381)

9fc9650

<!-- This change is generated by MagicModules. -->
/cc @rileykarson

modular-magician and others added 16 commits

December 14, 2018 09:50


          Remove deprecated fields from Snapshot (hashicorp#2624)

42b4ec4


          Update CHANGELOG.md

24f0308


          Mark the deleted field computed in google_project_iam_custom_role (ha…

b1d1901

…shicorp#2619)

<!-- This change is generated by MagicModules. -->
/cc @rileykarson


          Update CHANGELOG.md

648a054


          Various updates to the upgrade guide (hashicorp#2674)

d8471cf

<!-- This change is generated by MagicModules. -->
/cc @rileykarson


          Remove Firewall Service Account Limit (hashicorp#2656)

3ab9dbd


          Add data source for cloud bucket object (hashicorp#2657)

a2adc69

<!-- This change is generated by MagicModules. -->
/cc @chrisst


          [Terraform]: Apply gofmt -s to all files managed by MM (hashicorp#2676)

279a2a9

<!-- This change is generated by MagicModules. -->
/cc @rileykarson


          [Terraform]: Fix file not formatted with gofmt -s (hashicorp#2678)

<!-- This change is generated by MagicModules. -->
/cc @rileykarson


          Remove old schema generator. (hashicorp#2677)

13dee93

https://github.com/GoogleCloudPlatform/magic-modules


          Update .gometalinter.json (hashicorp#2675)

bd30d2c


          Various linter cleanups (conversions, unused, misspellings) (hashicor…

4254e68

…p#2681)

<!-- This change is generated by MagicModules. -->
/cc @rileykarson


          Add more linters to gometalinter (hashicorp#2680)

0aa6277


          Merge github.com:terraform-providers/terraform-provider-google

82aa20a


          Merge with master

c9aaa22


          Gofmt

bbbb0f6

This was referenced Dec 17, 2018

Added Storage Transfer package #2690

Merged

Added Storage Transfer package hashicorp/terraform-provider-google-beta#245

Merged

Contributor Author

akramhussein commented Dec 17, 2018

Hi @rileykarson - I'm making all these changes now.
Please ignore this PR as it's gone a bit haywire - everything is being done in new PRs.

I've so far created:

I believe I still need to add:

PR for Adding the storage transfer job resource to this repo and beta with also the line in the provider.go to hook it up?
PR for Adding the storage transfer service account datasource to this repo and beta with also the line in the provider.go to hook it up?

So 4 more PRs. Is that correct?

Collaborator

rileykarson commented Dec 17, 2018

Nope - you've submitted all the PRs you need. Magic Modules will create PRs against both repos, and files like provider.go can be modified inside MM: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/third_party/terraform/utils/provider.go.erb

Normally MM would auto-generate "downstream" PRs to this repo and the beta repo, but since you're a first time contributor each build needs to be triggered manually. I'll kick off a build once we've merged the vendoring changes. I believe once a PR has been submitted it will generate automatically, but I'm not 100% on that.

rileykarson pushed a commit that referenced this pull request


          Vendor Storage Transfer package (#2690)

c807d3a

FAO @rileykarson 

Part of multi-PR for adding support for Google Storage Transfer Service.

See #2181

rileykarson pushed a commit to hashicorp/terraform-provider-google-beta that referenced this pull request


          Added Storage Transfer package (#245)

51920e5

FAO @rileykarson 

Part of multi-PR for adding support for Google Storage Transfer Service.

See [#2181](hashicorp/terraform-provider-google#2181)

Contributor Author

akramhussein commented Dec 21, 2018

@rileykarson can this be closed now?

Contributor Author

akramhussein commented Dec 21, 2018

Also #1286

nat-henderson pushed a commit that referenced this pull request


          Vendor Storage Transfer package (#2690)

f9dea3b

FAO @rileykarson 

Part of multi-PR for adding support for Google Storage Transfer Service.

See #2181

nat-henderson pushed a commit that referenced this pull request


          Vendor Storage Transfer package (#2690)

26bdb57

FAO @rileykarson 

Part of multi-PR for adding support for Google Storage Transfer Service.

See #2181

Collaborator

rileykarson commented Dec 21, 2018

Yep, thanks! Superseded by GoogleCloudPlatform/magic-modules#1069

rileykarson closed this

ghost commented Jan 20, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

ghost locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels