Remove leftover beta tests/maps/resources from GA provider. #631
Conversation
rileykarson
changed the title
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
| @@ -100,10 +101,14 @@ func Provider() terraform.ResourceProvider { | |||
| }, | |||
|
|
|||
| ResourcesMap: mergeResourceMaps( | |||
| <% if !version.nil? && version == 'beta' -%> | |||
There was a problem hiding this comment.
I've been doing <% unless version.nil? || version == 'ga' -%> instead since then we don't have to change anything if we introduce an alpha provider.
rileykarson
changed the title
|
@danawillow: I decided that it wouldn't make sense to just knock out |
rileykarson
changed the title
|
Also failures are expected until hashicorp/terraform-provider-google#2355. I don't have a great solution here other than temporarily breaking HEAD until the MM PR can build and get merged in; it works on my machine, but this isn't a case MM handles great. If you can review this w/o the outputs, I'll then merge hashicorp/terraform-provider-google#2355 and kick-start the magician to generate the downstreams and get reviews from you on those. |
| @@ -152,7 +154,8 @@ resource "google_binary_authorization_attestor" "attestor" { | |||
| note_reference = "${google_container_analysis_note.note.name}" | |||
| public_keys { | |||
| ascii_armored_pgp_public_key = <<EOF | |||
| %s | |||
| <%- # load bearing - the erb compiler will interpret the %s as ruby otherwise -%> | |||
There was a problem hiding this comment.
oh that's very upsetting
Remove the files we skip now with GoogleCloudPlatform/magic-modules#631
rileykarson
force-pushed
the
beta-provider
branch
4 times, most recently
from
1a23baf to
4f761c3
Compare
rileykarson
force-pushed
the
beta-provider
branch
from
4f761c3 to
3c7e98e
Compare
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 8436d0a) have been included in your existing downstream PRs. |
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
beta-provider
branch
from
3c7e98e to
f59d2c0
Compare
Remove the files we skip now with GoogleCloudPlatform/magic-modules#631
Remove the files we skip now with GoogleCloudPlatform/magic-modules#631
I don't think we can get cross-product information in a single run, so we need to do this by hand instead of
magic[all]
[terraform]
Remove beta generated resource maps from GA provider.
[terraform-beta]
Unintended changes
[ansible]
[inspec]