Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terraform]: Add data_source_google_storage_transfer_project_service_account #1068

Conversation

akramhussein
Copy link
Contributor


[all]

[terraform]

Add google_storage_transfer_project_service_account data_source

[terraform-beta]

[ansible]

[inspec]

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding the datasource in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/third_party/terraform/utils/provider.go.erb? I'll kick off the first run of the Magician without that, and rerun when it's merged.

@akramhussein
Copy link
Contributor Author

Done.

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#247
depends: hashicorp/terraform-provider-google#2692

@rileykarson
Copy link
Member

Ah! Looks like conflicts were introduced. That's my bad in #1065 I think. I'm going to click the resolve conflicts button & hope it works, this PR lgtm.

@rileykarson
Copy link
Member

Ah my bad, looks like I didn't notice that there were tabs inserted; sorry for making commits against this, I thought I was gonna be able to press the merge button right after. Do you mind replacing the tabs in the datasource map with spaces?

@akramhussein
Copy link
Contributor Author

Done!

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 7e9ce57) have been included in your existing downstream PRs.

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass in CI & LGTM 👍. Thanks for the contribution!

@rileykarson
Copy link
Member

Looks like I spoke a little too soon, I got a merge conflict while running the Magician CI's merge command. Do you mind rebasing these changes on top of master and/or squashing them into a single commit?

@akramhussein akramhussein force-pushed the tf-data-source-google_storage_transfer_project_service_account branch from 9e870e5 to 5392175 Compare December 18, 2018 00:25
@akramhussein akramhussein force-pushed the tf-data-source-google_storage_transfer_project_service_account branch from 5392175 to 859d9fb Compare December 18, 2018 00:26
@akramhussein
Copy link
Contributor Author

Is that ok?

Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 8721665 into GoogleCloudPlatform:master Dec 18, 2018
@rileykarson
Copy link
Member

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants