-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Storage Transfer package #2690
Added Storage Transfer package #2690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for splitting this up! Do you mind vendoring at the commit 04bb50b6b83d0e72253821af8cf3252d8e866517
? We're migrating from govendor over to go modules sometime in the next couple weeks, and my understanding of the requirements for that is that every package under a repo needs to share the same SHA.
Done. |
My apologies for the extra round trip here! I missed this the first time. Can you make the changes to Feel free to submit separately or as a part of GoogleCloudPlatform/magic-modules#1068 |
I've added it to GoogleCloudPlatform/magic-modules#1068 Do you need me to remove it from here? |
If you don't mind! Magic Modules will attempt to remove it in every PR until the MM pr is merged. Sorry for the weirdness around vendoring new packages with MM, it's a little silly how we end up needing to break changes up. |
No worries - done now. Will do in |
Done in |
If you don't mind! If you're unable to, the |
FAO @rileykarson Part of multi-PR for adding support for Google Storage Transfer Service. See #2181
FAO @rileykarson Part of multi-PR for adding support for Google Storage Transfer Service. See #2181
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
FAO @rileykarson
Part of multi-PR for adding support for Google Storage Transfer Service.
See #2181