Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Storage Transfer package #2690

Merged
merged 3 commits into from
Dec 17, 2018

Conversation

akramhussein
Copy link
Contributor

@akramhussein akramhussein commented Dec 17, 2018

FAO @rileykarson

Part of multi-PR for adding support for Google Storage Transfer Service.

See #2181

Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting this up! Do you mind vendoring at the commit 04bb50b6b83d0e72253821af8cf3252d8e866517? We're migrating from govendor over to go modules sometime in the next couple weeks, and my understanding of the requirements for that is that every package under a repo needs to share the same SHA.

@akramhussein
Copy link
Contributor Author

Done.

@rileykarson
Copy link
Collaborator

My apologies for the extra round trip here! I missed this the first time. Can you make the changes to config.go against this file? https://github.com/GoogleCloudPlatform/magic-modules/blob/master/third_party/terraform/utils/config.go.erb

Feel free to submit separately or as a part of GoogleCloudPlatform/magic-modules#1068

@akramhussein
Copy link
Contributor Author

I've added it to GoogleCloudPlatform/magic-modules#1068

Do you need me to remove it from here?

@rileykarson
Copy link
Collaborator

If you don't mind! Magic Modules will attempt to remove it in every PR until the MM pr is merged. Sorry for the weirdness around vendoring new packages with MM, it's a little silly how we end up needing to break changes up.

@akramhussein
Copy link
Contributor Author

No worries - done now. Will do in beta too.

@akramhussein
Copy link
Contributor Author

Done in beta. Is all that remains is me to sign the CLA?

@rileykarson
Copy link
Collaborator

If you don't mind! If you're unable to, the third_party/ directory doesn't require it, the bot just doesn't know that. I'll merge these vendor PRs as Travis finishes & start running the Magician to generate downstreams on GoogleCloudPlatform/magic-modules#1068.

@rileykarson rileykarson merged commit c807d3a into hashicorp:2.0.0 Dec 17, 2018
nat-henderson pushed a commit that referenced this pull request Dec 21, 2018
FAO @rileykarson 

Part of multi-PR for adding support for Google Storage Transfer Service.

See #2181
nat-henderson pushed a commit that referenced this pull request Dec 21, 2018
FAO @rileykarson 

Part of multi-PR for adding support for Google Storage Transfer Service.

See #2181
@ghost
Copy link

ghost commented Jan 17, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants