Generate DefaultObjectAccessControl in Terraform #630
Conversation
| @@ -146,11 +146,13 @@ def oics_link | |||
| end | |||
|
|
|||
| def substitute_test_paths(config) | |||
| config = config.gsub('../static/img/header-logo.png', 'test-fixtures/header-logo.png') | |||
There was a problem hiding this comment.
Why does the png need to be checked into source control?
There was a problem hiding this comment.
We need something to send up to our bucket, and I prefer sending "real" files up to just generating the file at test time. We already have a few static files for ssl certs and cloud functions, so I figure this image can be too.
There was a problem hiding this comment.
As long as we keep the file sizes small and don't change them much it shouldn't be a big deal. Big or frequently changing binary files make git sad.
There was a problem hiding this comment.
oh yup it is a 16x16 grey image very much on purpose haha. imo tossing 1-2 small images into vcs is fine, if it were any more/any larger it would 100% be time for a more future-proof solution
blocking GoogleCloudPlatform/magic-modules#630 This resource won't be tested between this merging and the MM pr merging
rileykarson
force-pushed
the
default-object-access
branch
2 times, most recently
from
cfa0efb to
aabd95b
Compare
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
rileykarson
force-pushed
the
default-object-access
branch
from
ca3cf79 to
41d1fd5
Compare
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 3616c0a) have been included in your existing downstream PRs. |
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 62167f1) have been included in your existing downstream PRs. |
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
blocking GoogleCloudPlatform/magic-modules#630 This resource won't be tested between this merging and the MM pr merging
blocking GoogleCloudPlatform/magic-modules#630 This resource won't be tested between this merging and the MM pr merging
blocking GoogleCloudPlatform/magic-modules#630 This resource won't be tested between this merging and the MM pr merging
blocking GoogleCloudPlatform/magic-modules#630 This resource won't be tested between this merging and the MM pr merging
blocking GoogleCloudPlatform/magic-modules#630 This resource won't be tested between this merging and the MM pr merging
blocking GoogleCloudPlatform/magic-modules#630 This resource won't be tested between this merging and the MM pr merging
Also add OiCS to ObjectAccessControl.
[all]
Update DefaultObjectAccessControl properties
[terraform]
Generate DefaultObjectAccessControl in Terraform
[terraform-beta]
[ansible]
[inspec]