Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable noImplicitAny in the tsconfig #313

Closed
JustinBeckwith opened this issue Nov 2, 2018 · 0 comments
Closed

Enable noImplicitAny in the tsconfig #313

JustinBeckwith opened this issue Nov 2, 2018 · 0 comments
Assignees
@jkwlui
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. help wanted We'd love to have community involvement on this issue. type: cleanup An internal cleanup or hygiene concern. TypeScript

Comments

@JustinBeckwith
Copy link
Contributor

JustinBeckwith commented Nov 2, 2018 •
edited
Loading

The goal here is to provide perfect TypeScript types for customers using the module. Generally when doing this work I like to:

  1. enable noImplicitAny in the tsconfig
  2. Choose a single file to get passing, and fix all errors in that file (using VSCode here is really useful)
  3. disablenoImplicitAny
  4. Get all the tests passing
  5. Submit a PR for just the single file I updated
  6. Repeat until finished

It's a lot easier if we do a PR per file on this one. 
@JustinBeckwith JustinBeckwith added type: cleanup An internal cleanup or hygiene concern. TypeScript labels Nov 2, 2018
@JustinBeckwith JustinBeckwith added the help wanted We'd love to have community involvement on this issue. label Nov 16, 2018
@jkwlui jkwlui self-assigned this Nov 21, 2018
@josecervino josecervino mentioned this issue Jan 21, 2019
Merged
3 tasks
@praveenqlogic praveenqlogic mentioned this issue Feb 11, 2019
Merged
3 tasks
@callmehiphop callmehiphop mentioned this issue Feb 15, 2019
Closed
@praveenqlogic praveenqlogic mentioned this issue Feb 15, 2019
Merged
3 tasks
This was referenced Feb 18, 2019
Merged
Merged
Merged
yoshi-automation pushed a commit that referenced this issue Feb 19, 2019
@praveenqlogic @yoshi-automation
refactor(typescript): noImplicityAny for Topic test file
19b8ab4 
refactor(typescript): noImplicityAny for Topic test file

refactor(typescript) changes for #313 (it's a good idea to open an issue first for discussion)

- [ ] Tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)


#487 automerged by dpebot
This was referenced Feb 27, 2019
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@praveenqlogic praveenqlogic mentioned this issue Mar 8, 2019
Merged
3 tasks
@google-cloud-label-sync google-cloud-label-sync bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Jan 31, 2020
feywind pushed a commit to feywind/nodejs-pubsub that referenced this issue Nov 12, 2024
@dpebot @JustinBeckwith
Update the kokoro config (googleapis#313)
6c357b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkwlui jkwlui

Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. help wanted We'd love to have community involvement on this issue. type: cleanup An internal cleanup or hygiene concern. TypeScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JustinBeckwith @jkwlui