Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(typescript): noImplicitAny for subscription test file #489

Conversation

praveenqlogic
Copy link
Contributor

towards #313 (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2019
@JustinBeckwith
Copy link
Contributor

Still seeing some weird stuff here with grpc-js @callmehiphop @alexander-fenster

 1) pubsub
       Subscription
         should ack the message:
     Error: stream.push() after EOF (and Mocha's done() called multiple times)
      at readableAddChunk (_stream_readable.js:240:30)
      at ClientDuplexStreamImpl.Readable.push (_stream_readable.js:208:10)
      at Http2CallStream.call.on (node_modules/@grpc/grpc-js/build/src/call.js:36:21)
      at addChunk (_stream_readable.js:263:12)
      at readableAddChunk (_stream_readable.js:250:11)
      at Http2CallStream.Readable.push (_stream_readable.js:208:10)
      at Http2CallStream.handleFilteredRead (node_modules/@grpc/grpc-js/build/src/call-stream.js:75:23)
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:189:7)
  2) pubsub
       Subscription
         should ack the message:
     Error: stream.push() after EOF (and Mocha's done() called multiple times)
      at readableAddChunk (_stream_readable.js:240:30)
      at ClientDuplexStreamImpl.Readable.push (_stream_readable.js:208:10)
      at Http2CallStream.call.on (node_modules/@grpc/grpc-js/build/src/call.js:36:21)
      at addChunk (_stream_readable.js:263:12)
      at readableAddChunk (_stream_readable.js:250:11)
      at Http2CallStream.Readable.push (_stream_readable.js:208:10)
      at Http2CallStream.handleFilteredRead (node_modules/@grpc/grpc-js/build/src/call-stream.js:75:23)
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:189:7)
  3) pubsub
       Subscription
         should nack the message:
     Error: stream.push() after EOF (and Mocha's done() called multiple times)
      at readableAddChunk (_stream_readable.js:240:30)
      at ClientDuplexStreamImpl.Readable.push (_stream_readable.js:208:10)
      at Http2CallStream.call.on (node_modules/@grpc/grpc-js/build/src/call.js:36:21)
      at addChunk (_stream_readable.js:263:12)
      at readableAddChunk (_stream_readable.js:250:11)
      at Http2CallStream.Readable.push (_stream_readable.js:208:10)
      at Http2CallStream.handleFilteredRead (node_modules/@grpc/grpc-js/build/src/call-stream.js:75:23)
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:189:7)
  4) pubsub
       Subscription
         should nack the message:
     Error: stream.push() after EOF (and Mocha's done() called multiple times)
      at readableAddChunk (_stream_readable.js:240:30)
      at ClientDuplexStreamImpl.Readable.push (_stream_readable.js:208:10)
      at Http2CallStream.call.on (node_modules/@grpc/grpc-js/build/src/call.js:36:21)
      at addChunk (_stream_readable.js:263:12)
      at readableAddChunk (_stream_readable.js:250:11)
      at Http2CallStream.Readable.push (_stream_readable.js:208:10)
      at Http2CallStream.handleFilteredRead (node_modules/@grpc/grpc-js/build/src/call-stream.js:75:23)
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:189:7)
  5) pubsub
       Subscription
         should respect flow control limits:
     Error: done() called multiple times
      at _subscriber.close.then (src/subscription.ts:304:41)
      at <anonymous>
  6) pubsub
       Subscription
         should respect flow control limits:
     Error: done() called multiple times
      at _subscriber.close.then (src/subscription.ts:304:41)
      at <anonymous>

@JustinBeckwith JustinBeckwith merged commit 4b88b91 into googleapis:master Feb 19, 2019
@callmehiphop
Copy link
Contributor

The Error: stream.push() after EOF errors look like a grpc error to me.

feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants