refactor(typescript):noImplicitAny for index test file #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
praveenqlogic
requested review from
callmehiphop,
JustinBeckwith and
AVaksman
and removed request for
callmehiphop
JustinBeckwith
suggested changes
Feb 27, 2019
praveenqlogic
force-pushed
the
nodejs-pubsub-tb-dev-test-index
branch
from
04f3b1a to
65094eb
Compare
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
- Coverage 94.97% 94.95% -0.03%
==========================================
Files 16 16
Lines 996 992 -4
Branches 87 87
==========================================
- Hits 946 942 -4
Misses 42 42
Partials 8 8
Continue to review full report at Codecov.
|
JustinBeckwith
suggested changes
Feb 28, 2019
praveenqlogic
force-pushed
the
nodejs-pubsub-tb-dev-test-index
branch
from
79889b3 to
8f27298
Compare
3 tasks
JustinBeckwith
suggested changes
Mar 1, 2019
praveenqlogic
force-pushed
the
nodejs-pubsub-tb-dev-test-index
branch
from
6d745d2 to
87abb7b
Compare
|
@praveenqlogic apologies, few merge conflicts here now. Can you merge and update? |
praveenqlogic
force-pushed
the
nodejs-pubsub-tb-dev-test-index
branch
from
87abb7b to
218eec8
Compare
|
@JustinBeckwith : Hi merge conflict get resolved. let me know if any change needed. |
JustinBeckwith
approved these changes
Mar 4, 2019
feywind
pushed a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 12, 2024
…is#502) * fix(docs): reference docs should link to section of googleapis.dev with API reference * fix(docs): make anchors work in jsdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #313 (it's a good idea to open an issue first for discussion)