refactor(typescript): noImplicityAny for snapshot.ts and publisher.ts #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Greetings! Drop me a note when the tests are passing and I'll take a look :) |
AVaksman
reviewed
Jan 31, 2019
AVaksman
reviewed
Jan 31, 2019
callmehiphop
suggested changes
Jan 31, 2019
praveenqlogic
force-pushed
the
nodejs-pubsub-tb-dev-snapshot-01
branch
from
019728f to
03de986
Compare
|
@JustinBeckwith Hi, tests are passing, please take a look into it. |
callmehiphop
suggested changes
Feb 4, 2019
|
I totally defer to @callmehiphop on this one 👍 |
praveenqlogic
force-pushed
the
nodejs-pubsub-tb-dev-snapshot-01
branch
from
03de986 to
ad83a2c
Compare
callmehiphop
suggested changes
Feb 5, 2019
praveenqlogic
force-pushed
the
nodejs-pubsub-tb-dev-snapshot-01
branch
from
ad83a2c to
7bd7cb0
Compare
callmehiphop
approved these changes
Feb 7, 2019
praveenqlogic
force-pushed
the
nodejs-pubsub-tb-dev-snapshot-01
branch
from
7bd7cb0 to
a0c728e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)
steps
enable noImplicityAny, for snapshot.ts and publisher.ts file in SRC folder!