-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(typescript): noImplicityAny for topic.ts and subscription.ts #420
refactor(typescript): noImplicityAny for topic.ts and subscription.ts #420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! One piece missing though is a.) how you generate the pubsub.d.ts
, and b.) making sure it gets copied to the output directory. Please see https://github.com/googleapis/nodejs-logging/blob/master/package.json for an example of how to do both :)
@JustinBeckwith Hi, i generated a pubsub.d.ts using a below script "mkdir -p proto && pbjs -t static-module -w commonjs -p node_modules/google-proto-files google/pubsub/v1/pubsub.proto | pbts -o proto/pubsub.d.ts -" please let me know if i need to commit anything in this regard! |
@praveenqlogic please add |
|
f62c061
to
fcd6628
Compare
…logic/nodejs-pubsub into nodejs-pubsub-tb-dev-01
@JustinBeckwith Hi, let me know if any changes needed on this PR, Hope you like the changes and approve it. |
(To create a reference to issue page) Part of #313 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're so close!
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)
steps
enable noImplicityAny, for subscription.ts and topic.ts file in SRC folder!