Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

updated tests to avoid confusion #57

Merged
merged 1 commit into from
Jun 27, 2018

Conversation

prateek3255
Copy link
Contributor

@prateek3255 prateek3255 commented Jun 26, 2018

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #15012 in freeCodeCamp repository

Description

I have already submitted #17571 pull request in the freeCodeCamp repository for the same issue, all the tests passed successfully, the QA was also complete and it was ready to be merged.

@scissorsneedfoodtoo scissorsneedfoodtoo merged commit 7492c27 into freeCodeCamp:dev Jun 27, 2018
@scissorsneedfoodtoo
Copy link
Contributor

✨ ✨ ✨ Awesome! Congratulations on your first contribution to freeCodeCamp! ✨ ✨ ✨

Thank you for submitting a PRs for this issue, @prateek3255, and especially for moving it to this new repo. We're all really looking forward to your next contribution!

raisedadead pushed a commit that referenced this pull request Jun 29, 2018
# [3.0.0](v2.0.0...v3.0.0) (2018-06-29)

### Bug Fixes

* **challenge:** Fixed the typo for automatically ([#48](#48)) ([dd046d6](dd046d6))
* **challenge:** Updated tests to avoid confusion ([#57](#57)) ([7105507](7105507))
* **challenges:** change test for template literals challenge ([#37](#37)) ([4b1c5eb](4b1c5eb))
* **challenges:** cherry pick pr 17664 & 17672 from main repo ([#52](#52)) ([2375d0c](2375d0c))
* **challenges:** fixed telephone number validator project ([#53](#53)) ([2b034e2](2b034e2)), closes [#47](#47)
* **challenges:** fixed typo in css-grid.json ([#46](#46)) ([e74192e](e74192e))
* **challenges:** grammar fix in css-grid auto-fit challenge ([#60](#60)) ([a6a0266](a6a0266))
* **challenges:** Typo errors ([#39](#39)) ([0c0702d](0c0702d))
* **challenges:** update regular expression that fails ([#56](#56)) ([9fa5907](9fa5907)), closes [#55](#55)

### BREAKING CHANGES

* **challenges:** None
raisedadead pushed a commit that referenced this pull request Jun 29, 2018
# [3.0.0](v2.0.0...v3.0.0) (2018-06-29)

### Bug Fixes

* **challenge:** Fixed the typo for automatically ([#48](#48)) ([dd046d6](dd046d6))
* **challenge:** Updated tests to avoid confusion ([#57](#57)) ([7105507](7105507))
* **challenges:** change test for template literals challenge ([#37](#37)) ([4b1c5eb](4b1c5eb))
* **challenges:** cherry pick pr 17664 & 17672 from main repo ([#52](#52)) ([2375d0c](2375d0c))
* **challenges:** fixed telephone number validator project ([#53](#53)) ([2b034e2](2b034e2)), closes [#47](#47)
* **challenges:** fixed typo in css-grid.json ([#46](#46)) ([e74192e](e74192e))
* **challenges:** grammar fix in css-grid auto-fit challenge ([#60](#60)) ([a6a0266](a6a0266))
* **challenges:** Typo errors ([#39](#39)) ([0c0702d](0c0702d))
* **challenges:** update regular expression that fails ([#56](#56)) ([9fa5907](9fa5907)), closes [#55](#55)

### BREAKING CHANGES

* **challenges:** None
anku255 pushed a commit to anku255/curriculum that referenced this pull request Jun 30, 2018
# [3.0.0](freeCodeCamp/curriculum@v2.0.0...v3.0.0) (2018-06-29)

### Bug Fixes

* **challenge:** Fixed the typo for automatically ([freeCodeCamp#48](freeCodeCamp#48)) ([dd046d6](freeCodeCamp@dd046d6))
* **challenge:** Updated tests to avoid confusion ([freeCodeCamp#57](freeCodeCamp#57)) ([7105507](freeCodeCamp@7105507))
* **challenges:** change test for template literals challenge ([freeCodeCamp#37](freeCodeCamp#37)) ([4b1c5eb](freeCodeCamp@4b1c5eb))
* **challenges:** cherry pick pr 17664 & 17672 from main repo ([freeCodeCamp#52](freeCodeCamp#52)) ([2375d0c](freeCodeCamp@2375d0c))
* **challenges:** fixed telephone number validator project ([freeCodeCamp#53](freeCodeCamp#53)) ([2b034e2](freeCodeCamp@2b034e2)), closes [freeCodeCamp#47](freeCodeCamp#47)
* **challenges:** fixed typo in css-grid.json ([freeCodeCamp#46](freeCodeCamp#46)) ([e74192e](freeCodeCamp@e74192e))
* **challenges:** grammar fix in css-grid auto-fit challenge ([freeCodeCamp#60](freeCodeCamp#60)) ([a6a0266](freeCodeCamp@a6a0266))
* **challenges:** Typo errors ([freeCodeCamp#39](freeCodeCamp#39)) ([0c0702d](freeCodeCamp@0c0702d))
* **challenges:** update regular expression that fails ([freeCodeCamp#56](freeCodeCamp#56)) ([9fa5907](freeCodeCamp@9fa5907)), closes [freeCodeCamp#55](freeCodeCamp#55)

### BREAKING CHANGES

* **challenges:** None
ojeytonwilliams pushed a commit to ojeytonwilliams/curriculum that referenced this pull request Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing this challenge is very tricky - this can cause confusion
2 participants