fix(challenges): update regular expression that fails

[matthew-t-smith]

Changes regular expression in testString to remove negative look behind that is not implemented
across all browsers.

ISSUES CLOSED: #55

Pre-Submission Checklist

• Your pull request targets the staging branch of freeCodeCamp.
  Targets new dev branch of curriculum
• Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
• You have only one commit (if not, squash them into one commit).
• All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

• Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)
• Add new translation (feature adding new translations)

Checklist:

• Tested changes locally.
• Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #55
freeCodeCamp/freeCodeCamp#17387

Description

This replicates a PR that was closed on freeCodeCamp (noted in the Issue #55 ) in order to remove a negative look behind used in the regular expression in a test. This is not fully implemented in Firefox yet, but the new expression should take care of the testing as it should.

[matthew-t-smith]

@raisedadead @scissorsneedfoodtoo Here is the new issue & PR duplicating what we did over on freeCodeCamp. Let me know if there's anything else you need!

[scissorsneedfoodtoo]

@matthew-t-smith, thank you for moving your PR to this repo!

I'm sorry, there's just one thing I noticed. Not sure why, but a lot of the spacing was added to the tests objects. Maybe one of the tests or a linter added all of these line breaks? Unfortunately, I'm not sure if we can merge this as the formatting is quite a bit different than the other seed files.

This isn't the challenge you're updating, but here's an example of the format for the tests.

      "tests": [
        {
          "text": "Your code should use <code>console.log()</code> to check the value of the variable <code>a</code>.",
          "testString": "assert(code.match(/console\\.log\\(a\\)/g), 'Your code should use <code>console.log()</code> to check the value of the variable <code>a</code>.');"
        }
      ],

Would you be able to update this pull request so that the tests look like the one above, without all of the line breaks?

[matthew-t-smith]

@scissorsneedfoodtoo I just updated removing all the line breaks. It was happening during the npm run commit on my computer. It has something to do with the character length of each line. Shorter titles and test strings didn't jump.

However, now my Travis CI has 1 failing check. I'll look into this evening.

[scissorsneedfoodtoo]

@matthew-t-smith, you're right, I checked on my local machine and the same happens automatically. I checked some other challenge files and you're right--shorter titles and test strings are all on the same line. Sorry about that! Didn't realize until now.

Could you roll back to your previous commit, or just run npm run commit again to get things back the way they were? I'm sorry again for all the trouble.

[raisedadead]

We have turned on prettier formatting. Its worth investigating if this is okay or not for certain files. Is the spacing an issue on the final outputs?

[scissorsneedfoodtoo]

@raisedadead, good point. Seems like a lot of the basic Javascript challenges were formatted that way. I can take a quick look and see if the spacing is an issue before @matthew-t-smith makes any further changes.

[scissorsneedfoodtoo]

@raisedadead, I checked out a handful of challenges with the new prettier formatting and it doesn't seem to affect the final output at all--the pages over on Learn look as they should.

@matthew-t-smith, could you go back the initial formatting you had? Sorry again for all the trouble!

[matthew-t-smith]

@scissorsneedfoodtoo This should be back to what the initial commit showed - added line spacing from the prettier formatting but with the regex changed.

[scissorsneedfoodtoo]

@matthew-t-smith, awesome! That was so fast. Thank you again for making all of these changes and going back and forth like that. Everything LGTM 👍