This repository has been archived by the owner on Sep 25, 2019. It is now read-only.
fix(challenges): fixed telephone number validator project #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed telephone number validator projects to show example telephone numbers on new lines ISSUES CLOSED: #47
|
@gforce2k5, thank you for submitting a PR to fix this issue. Your changes look good! But I noticed that your changes are from an unknown repository. Did you make your changes directly in the web editor? If so, I'm not sure if we can merge this. Unfortunately, you may have to close this and submit another PR. What do you think, @raisedadead? |
|
It happened because I deleted the repo from my user repo after submitting this PR |
|
@scissorsneedfoodtoo if the changes are good, this maybe merged. If they need to make additional changes, they would have to close and make a fresh PR. |
|
@raisedadead, thank you! I'll keep that in mind for future QAing. |
|
✨ ✨ ✨ Awesome! Congratulations on your first contribution to freeCodeCamp! ✨ ✨ ✨ Thank you for submitting a PR for this issue, @gforce2k5. We're all really looking forward to your next contributions. |
raisedadead
pushed a commit
that referenced
this pull request
Jun 29, 2018
fixed telephone number validator projects to show example telephone numbers on new lines ISSUES CLOSED: #47
raisedadead
pushed a commit
that referenced
this pull request
Jun 29, 2018
fixed telephone number validator projects to show example telephone numbers on new lines ISSUES CLOSED: #47
raisedadead
pushed a commit
that referenced
this pull request
Jun 29, 2018
# [3.0.0](v2.0.0...v3.0.0) (2018-06-29) ### Bug Fixes * **challenge:** Fixed the typo for automatically ([#48](#48)) ([dd046d6](dd046d6)) * **challenge:** Updated tests to avoid confusion ([#57](#57)) ([7105507](7105507)) * **challenges:** change test for template literals challenge ([#37](#37)) ([4b1c5eb](4b1c5eb)) * **challenges:** cherry pick pr 17664 & 17672 from main repo ([#52](#52)) ([2375d0c](2375d0c)) * **challenges:** fixed telephone number validator project ([#53](#53)) ([2b034e2](2b034e2)), closes [#47](#47) * **challenges:** fixed typo in css-grid.json ([#46](#46)) ([e74192e](e74192e)) * **challenges:** grammar fix in css-grid auto-fit challenge ([#60](#60)) ([a6a0266](a6a0266)) * **challenges:** Typo errors ([#39](#39)) ([0c0702d](0c0702d)) * **challenges:** update regular expression that fails ([#56](#56)) ([9fa5907](9fa5907)), closes [#55](#55) ### BREAKING CHANGES * **challenges:** None
raisedadead
pushed a commit
that referenced
this pull request
Jun 29, 2018
# [3.0.0](v2.0.0...v3.0.0) (2018-06-29) ### Bug Fixes * **challenge:** Fixed the typo for automatically ([#48](#48)) ([dd046d6](dd046d6)) * **challenge:** Updated tests to avoid confusion ([#57](#57)) ([7105507](7105507)) * **challenges:** change test for template literals challenge ([#37](#37)) ([4b1c5eb](4b1c5eb)) * **challenges:** cherry pick pr 17664 & 17672 from main repo ([#52](#52)) ([2375d0c](2375d0c)) * **challenges:** fixed telephone number validator project ([#53](#53)) ([2b034e2](2b034e2)), closes [#47](#47) * **challenges:** fixed typo in css-grid.json ([#46](#46)) ([e74192e](e74192e)) * **challenges:** grammar fix in css-grid auto-fit challenge ([#60](#60)) ([a6a0266](a6a0266)) * **challenges:** Typo errors ([#39](#39)) ([0c0702d](0c0702d)) * **challenges:** update regular expression that fails ([#56](#56)) ([9fa5907](9fa5907)), closes [#55](#55) ### BREAKING CHANGES * **challenges:** None
anku255
pushed a commit
to anku255/curriculum
that referenced
this pull request
Jun 30, 2018
# [3.0.0](freeCodeCamp/curriculum@v2.0.0...v3.0.0) (2018-06-29) ### Bug Fixes * **challenge:** Fixed the typo for automatically ([freeCodeCamp#48](freeCodeCamp#48)) ([dd046d6](freeCodeCamp@dd046d6)) * **challenge:** Updated tests to avoid confusion ([freeCodeCamp#57](freeCodeCamp#57)) ([7105507](freeCodeCamp@7105507)) * **challenges:** change test for template literals challenge ([freeCodeCamp#37](freeCodeCamp#37)) ([4b1c5eb](freeCodeCamp@4b1c5eb)) * **challenges:** cherry pick pr 17664 & 17672 from main repo ([freeCodeCamp#52](freeCodeCamp#52)) ([2375d0c](freeCodeCamp@2375d0c)) * **challenges:** fixed telephone number validator project ([freeCodeCamp#53](freeCodeCamp#53)) ([2b034e2](freeCodeCamp@2b034e2)), closes [freeCodeCamp#47](freeCodeCamp#47) * **challenges:** fixed typo in css-grid.json ([freeCodeCamp#46](freeCodeCamp#46)) ([e74192e](freeCodeCamp@e74192e)) * **challenges:** grammar fix in css-grid auto-fit challenge ([freeCodeCamp#60](freeCodeCamp#60)) ([a6a0266](freeCodeCamp@a6a0266)) * **challenges:** Typo errors ([freeCodeCamp#39](freeCodeCamp#39)) ([0c0702d](freeCodeCamp@0c0702d)) * **challenges:** update regular expression that fails ([freeCodeCamp#56](freeCodeCamp#56)) ([9fa5907](freeCodeCamp@9fa5907)), closes [freeCodeCamp#55](freeCodeCamp#55) ### BREAKING CHANGES * **challenges:** None
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed telephone number validator projects to show example telephone numbers on new lines
ISSUES CLOSED: #47
Pre-Submission Checklist
stagingbranch of freeCodeCamp.fix/,feature/, ortranslate/(e.g.fix/signin-issue)npm test. Usegit commit --amendto amend any fixes.Type of Change
Checklist:
Closes #47
Description