This repository has been archived by the owner on Sep 25, 2019. It is now read-only.
Regular Expression Error in Test for Debugging Challenge #55
Comments
matthew-t-smith
added a commit
to matthew-t-smith/curriculum
that referenced
this issue
Jun 26, 2018
Changes regular expression in testString to remove negative look behind that is not implemented across all browsers. ISSUES CLOSED: freeCodeCamp#55
10 tasks
scissorsneedfoodtoo
pushed a commit
that referenced
this issue
Jun 29, 2018
* fix(challenges): update regular expression that fails Changes regular expression in testString to remove negative look behind that is not implemented across all browsers. ISSUES CLOSED: #55 * Fixed line spacing It is definitely something to do with a linter. I re-ran the `npm run commit` in my own environment and watched the line spacing jump. Should probably be checked if it ends up happening to others. However, this should fix it all for this PR! * Back to `prettier` formatting Reverting back to pretty formatting from commit.
raisedadead
pushed a commit
that referenced
this issue
Jun 29, 2018
* fix(challenges): update regular expression that fails Changes regular expression in testString to remove negative look behind that is not implemented across all browsers. ISSUES CLOSED: #55 * Fixed line spacing It is definitely something to do with a linter. I re-ran the `npm run commit` in my own environment and watched the line spacing jump. Should probably be checked if it ends up happening to others. However, this should fix it all for this PR! * Back to `prettier` formatting Reverting back to pretty formatting from commit.
raisedadead
pushed a commit
that referenced
this issue
Jun 29, 2018
* fix(challenges): update regular expression that fails Changes regular expression in testString to remove negative look behind that is not implemented across all browsers. ISSUES CLOSED: #55 * Fixed line spacing It is definitely something to do with a linter. I re-ran the `npm run commit` in my own environment and watched the line spacing jump. Should probably be checked if it ends up happening to others. However, this should fix it all for this PR! * Back to `prettier` formatting Reverting back to pretty formatting from commit.
raisedadead
pushed a commit
that referenced
this issue
Jun 29, 2018
* fix(challenges): update regular expression that fails Changes regular expression in testString to remove negative look behind that is not implemented across all browsers. ISSUES CLOSED: #55 * Fixed line spacing It is definitely something to do with a linter. I re-ran the `npm run commit` in my own environment and watched the line spacing jump. Should probably be checked if it ends up happening to others. However, this should fix it all for this PR! * Back to `prettier` formatting Reverting back to pretty formatting from commit.
raisedadead
pushed a commit
that referenced
this issue
Jun 29, 2018
# [3.0.0](v2.0.0...v3.0.0) (2018-06-29) ### Bug Fixes * **challenge:** Fixed the typo for automatically ([#48](#48)) ([dd046d6](dd046d6)) * **challenge:** Updated tests to avoid confusion ([#57](#57)) ([7105507](7105507)) * **challenges:** change test for template literals challenge ([#37](#37)) ([4b1c5eb](4b1c5eb)) * **challenges:** cherry pick pr 17664 & 17672 from main repo ([#52](#52)) ([2375d0c](2375d0c)) * **challenges:** fixed telephone number validator project ([#53](#53)) ([2b034e2](2b034e2)), closes [#47](#47) * **challenges:** fixed typo in css-grid.json ([#46](#46)) ([e74192e](e74192e)) * **challenges:** grammar fix in css-grid auto-fit challenge ([#60](#60)) ([a6a0266](a6a0266)) * **challenges:** Typo errors ([#39](#39)) ([0c0702d](0c0702d)) * **challenges:** update regular expression that fails ([#56](#56)) ([9fa5907](9fa5907)), closes [#55](#55) ### BREAKING CHANGES * **challenges:** None
|
🎉 This issue has been resolved in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
raisedadead
pushed a commit
that referenced
this issue
Jun 29, 2018
# [3.0.0](v2.0.0...v3.0.0) (2018-06-29) ### Bug Fixes * **challenge:** Fixed the typo for automatically ([#48](#48)) ([dd046d6](dd046d6)) * **challenge:** Updated tests to avoid confusion ([#57](#57)) ([7105507](7105507)) * **challenges:** change test for template literals challenge ([#37](#37)) ([4b1c5eb](4b1c5eb)) * **challenges:** cherry pick pr 17664 & 17672 from main repo ([#52](#52)) ([2375d0c](2375d0c)) * **challenges:** fixed telephone number validator project ([#53](#53)) ([2b034e2](2b034e2)), closes [#47](#47) * **challenges:** fixed typo in css-grid.json ([#46](#46)) ([e74192e](e74192e)) * **challenges:** grammar fix in css-grid auto-fit challenge ([#60](#60)) ([a6a0266](a6a0266)) * **challenges:** Typo errors ([#39](#39)) ([0c0702d](0c0702d)) * **challenges:** update regular expression that fails ([#56](#56)) ([9fa5907](9fa5907)), closes [#55](#55) ### BREAKING CHANGES * **challenges:** None
anku255
pushed a commit
to anku255/curriculum
that referenced
this issue
Jun 30, 2018
* fix(challenges): update regular expression that fails Changes regular expression in testString to remove negative look behind that is not implemented across all browsers. ISSUES CLOSED: freeCodeCamp#55 * Fixed line spacing It is definitely something to do with a linter. I re-ran the `npm run commit` in my own environment and watched the line spacing jump. Should probably be checked if it ends up happening to others. However, this should fix it all for this PR! * Back to `prettier` formatting Reverting back to pretty formatting from commit.
anku255
pushed a commit
to anku255/curriculum
that referenced
this issue
Jun 30, 2018
# [3.0.0](freeCodeCamp/curriculum@v2.0.0...v3.0.0) (2018-06-29) ### Bug Fixes * **challenge:** Fixed the typo for automatically ([freeCodeCamp#48](freeCodeCamp#48)) ([dd046d6](freeCodeCamp@dd046d6)) * **challenge:** Updated tests to avoid confusion ([freeCodeCamp#57](freeCodeCamp#57)) ([7105507](freeCodeCamp@7105507)) * **challenges:** change test for template literals challenge ([freeCodeCamp#37](freeCodeCamp#37)) ([4b1c5eb](freeCodeCamp@4b1c5eb)) * **challenges:** cherry pick pr 17664 & 17672 from main repo ([freeCodeCamp#52](freeCodeCamp#52)) ([2375d0c](freeCodeCamp@2375d0c)) * **challenges:** fixed telephone number validator project ([freeCodeCamp#53](freeCodeCamp#53)) ([2b034e2](freeCodeCamp@2b034e2)), closes [freeCodeCamp#47](freeCodeCamp#47) * **challenges:** fixed typo in css-grid.json ([freeCodeCamp#46](freeCodeCamp#46)) ([e74192e](freeCodeCamp@e74192e)) * **challenges:** grammar fix in css-grid auto-fit challenge ([freeCodeCamp#60](freeCodeCamp#60)) ([a6a0266](freeCodeCamp@a6a0266)) * **challenges:** Typo errors ([freeCodeCamp#39](freeCodeCamp#39)) ([0c0702d](freeCodeCamp@0c0702d)) * **challenges:** update regular expression that fails ([freeCodeCamp#56](freeCodeCamp#56)) ([9fa5907](freeCodeCamp@9fa5907)), closes [freeCodeCamp#55](freeCodeCamp#55) ### BREAKING CHANGES * **challenges:** None
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Referencing Issue #17387 in freeCodeCamp/freeCodeCamp:
In the "Debugging: Understanding the Differences between the freeCodeCamp and Browser Console" challenge, a correct solution cannot pass because of a test failing due to the following:
It has been determined that this is likely because the negative look behind regular expression used is not fully implemented in Firefox yet.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The challenge should pass if the regular expression in the test is changed (this will be duplicating a PR that was closed under freeCodeCamp/freeCodeCamp so that it can be implemented here).
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: