Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

Telephone Number Validator - Examples are not presented on separate lines as expected #47

Closed
huyenltnguyen opened this issue Jun 25, 2018 · 2 comments · Fixed by #53
Closed

Telephone Number Validator - Examples are not presented on separate lines as expected #47

huyenltnguyen opened this issue Jun 25, 2018 · 2 comments · Fixed by #53

Comments

@huyenltnguyen
Copy link
Member

huyenltnguyen commented Jun 25, 2018 •
edited
Loading

Bug:
In the challenge description, the examples of valid phone number formats are not presented on separate lines as expected.

Link to the challenge: https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/javascript-algorithms-and-data-structures-projects/telephone-number-validator

Solution:
This is because HTML doesn't render \n to a new line, but a single space instead. We can fix it by replacing all the \n characters with <br> tags. Here is the line that needs to be edited:

curriculum/challenges/02-javascript-algorithms-and-data-structures/javascript-algorithms-and-data-structures-projects.json

Line 370 in 34f45d2

"<blockquote>555-555-5555\n(555)555-5555\n(555) 555-5555\n555 555 5555\n5555555555\n1 555 555 5555</blockquote>",

@gforce2k5
Copy link
Contributor

I'll fix it

@gforce2k5 gforce2k5 mentioned this issue Jun 25, 2018
Merged
10 tasks
scissorsneedfoodtoo pushed a commit that referenced this issue Jun 27, 2018
@gforce2k5 @scissorsneedfoodtoo
fix(challenges): fixed telephone number validator project (#53)
e185b55 
fixed telephone number validator projects to show example telephone numbers on new lines

ISSUES CLOSED: #47
raisedadead pushed a commit that referenced this issue Jun 29, 2018
@gforce2k5 @raisedadead
fix(challenges): fixed telephone number validator project (#53)
9d072c3 
fixed telephone number validator projects to show example telephone numbers on new lines

ISSUES CLOSED: #47
raisedadead pushed a commit that referenced this issue Jun 29, 2018
@gforce2k5 @raisedadead
fix(challenges): fixed telephone number validator project (#53)
2b034e2 
fixed telephone number validator projects to show example telephone numbers on new lines

ISSUES CLOSED: #47
raisedadead pushed a commit that referenced this issue Jun 29, 2018
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
ebf0399 
# [3.0.0](v2.0.0...v3.0.0) (2018-06-29)

### Bug Fixes

* **challenge:** Fixed the typo for automatically ([#48](#48)) ([dd046d6](dd046d6))
* **challenge:** Updated tests to avoid confusion ([#57](#57)) ([7105507](7105507))
* **challenges:** change test for template literals challenge ([#37](#37)) ([4b1c5eb](4b1c5eb))
* **challenges:** cherry pick pr 17664 & 17672 from main repo ([#52](#52)) ([2375d0c](2375d0c))
* **challenges:** fixed telephone number validator project ([#53](#53)) ([2b034e2](2b034e2)), closes [#47](#47)
* **challenges:** fixed typo in css-grid.json ([#46](#46)) ([e74192e](e74192e))
* **challenges:** grammar fix in css-grid auto-fit challenge ([#60](#60)) ([a6a0266](a6a0266))
* **challenges:** Typo errors ([#39](#39)) ([0c0702d](0c0702d))
* **challenges:** update regular expression that fails ([#56](#56)) ([9fa5907](9fa5907)), closes [#55](#55)

### BREAKING CHANGES

* **challenges:** None
@raisedadead
Copy link
Member

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

raisedadead pushed a commit that referenced this issue Jun 29, 2018
@semantic-release-bot @raisedadead
chore(release): 3.0.0 [skip ci]
9744d9f 
# [3.0.0](v2.0.0...v3.0.0) (2018-06-29)

### Bug Fixes

* **challenge:** Fixed the typo for automatically ([#48](#48)) ([dd046d6](dd046d6))
* **challenge:** Updated tests to avoid confusion ([#57](#57)) ([7105507](7105507))
* **challenges:** change test for template literals challenge ([#37](#37)) ([4b1c5eb](4b1c5eb))
* **challenges:** cherry pick pr 17664 & 17672 from main repo ([#52](#52)) ([2375d0c](2375d0c))
* **challenges:** fixed telephone number validator project ([#53](#53)) ([2b034e2](2b034e2)), closes [#47](#47)
* **challenges:** fixed typo in css-grid.json ([#46](#46)) ([e74192e](e74192e))
* **challenges:** grammar fix in css-grid auto-fit challenge ([#60](#60)) ([a6a0266](a6a0266))
* **challenges:** Typo errors ([#39](#39)) ([0c0702d](0c0702d))
* **challenges:** update regular expression that fails ([#56](#56)) ([9fa5907](9fa5907)), closes [#55](#55)

### BREAKING CHANGES

* **challenges:** None
anku255 pushed a commit to anku255/curriculum that referenced this issue Jun 30, 2018
@semantic-release-bot @anku255
chore(release): 3.0.0 [skip ci]
1f35ac3 
# [3.0.0](freeCodeCamp/curriculum@v2.0.0...v3.0.0) (2018-06-29)

### Bug Fixes

* **challenge:** Fixed the typo for automatically ([freeCodeCamp#48](freeCodeCamp#48)) ([dd046d6](freeCodeCamp@dd046d6))
* **challenge:** Updated tests to avoid confusion ([freeCodeCamp#57](freeCodeCamp#57)) ([7105507](freeCodeCamp@7105507))
* **challenges:** change test for template literals challenge ([freeCodeCamp#37](freeCodeCamp#37)) ([4b1c5eb](freeCodeCamp@4b1c5eb))
* **challenges:** cherry pick pr 17664 & 17672 from main repo ([freeCodeCamp#52](freeCodeCamp#52)) ([2375d0c](freeCodeCamp@2375d0c))
* **challenges:** fixed telephone number validator project ([freeCodeCamp#53](freeCodeCamp#53)) ([2b034e2](freeCodeCamp@2b034e2)), closes [freeCodeCamp#47](freeCodeCamp#47)
* **challenges:** fixed typo in css-grid.json ([freeCodeCamp#46](freeCodeCamp#46)) ([e74192e](freeCodeCamp@e74192e))
* **challenges:** grammar fix in css-grid auto-fit challenge ([freeCodeCamp#60](freeCodeCamp#60)) ([a6a0266](freeCodeCamp@a6a0266))
* **challenges:** Typo errors ([freeCodeCamp#39](freeCodeCamp#39)) ([0c0702d](freeCodeCamp@0c0702d))
* **challenges:** update regular expression that fails ([freeCodeCamp#56](freeCodeCamp#56)) ([9fa5907](freeCodeCamp@9fa5907)), closes [freeCodeCamp#55](freeCodeCamp#55)

### BREAKING CHANGES

* **challenges:** None
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(challenges): fixed telephone number validator project
3 participants
@raisedadead @gforce2k5 @huyenltnguyen