Generalizing Rich Command Usage

[QuaintMako]

Description

Thanks to @cinqmilleans' job, Files has now a cleaner way to handle commands across the solution. Rich commands now need to be implemented throughtout the whole solution.

This issue is used to keep track of which commands are made into Rich Commands.

Concerned code

The following commands must be transformed into Rich Commands (See BaseLayoutCommandsViewModel, ContextFlyoutItemHelper and ToolbarViewModel):

• Clear Selection (Feature: Add selection RichCommands #11502)
• Close Selected Tab (RichCommands: Switch tabs command #11916)
• Close Pane (RichCommands: Open & Close Pane #12002)
• Compress Into Archive (Rich Commands : "Compress into..." now as Rich Commands #11572)
• Compress Into Seven Zip (Rich Commands : "Compress into..." now as Rich Commands #11572)
• Compress Into Zip (Rich Commands : "Compress into..." now as Rich Commands #11572)
• Copy Item (Feature: Add Copy, Cut and Delete RichCommands #11504)
• Copy Path Of Selected Items (RichCommand: Copy path #11774)
• Create Folder With Selection
• Create New File
• Create New Folder (Feature: Implement more RichCommands #11493)
• Create Shortcut (Feature: Implement more RichCommands #11493)
• Create Shortcut From Dialog (Feature: Implement more RichCommands #11493)
• Cut Item (Feature: Add Copy, Cut and Delete RichCommands #11504)
• Decompress Archive (Rich Commands: Decompress Archive commands #11723)
• Decompress Archive Here (Rich Commands: Decompress Archive commands #11723)
• Decompress Archive To Child Folder (Rich Commands: Decompress Archive commands #11723)
• Delete Item (Feature: Add Copy, Cut and Delete RichCommands #11504)
• Duplicate Tab (Rich command: NewTab + DuplicateTab #11596)
• Empty Recycle Bin (RichCommand: Glyph + ContextMenu + EmptyRecycleBinAction #11415 )
• Enter compact overlay (RichCommands: EnterCompactOverlay, ExitCompactOverlay, ToggleCompactOverlay #11821)
• Exit compact overlay (RichCommands: EnterCompactOverlay, ExitCompactOverlay, ToggleCompactOverlay #11821)
• Format Drive RichCommands: Format Drive #11831
• Gridview Size Decrease (RichCommand: Layout Sort Group #11678)
• Gridview Size Increase (RichCommand: Layout Sort Group #11678)
• Group Layer Sort (RichCommand: Layout Sort Group #11678)
• Install Font (RichCommand: InstallFont #11780)
• Install Inf Driver (RichCommand: Install Inf Driver #11812)
• Invert Selection (Feature: Add selection RichCommands #11502)
• Multi-Selection (Feature: Add selection RichCommands #11502)
• Navigate back (RichCommands: Navigate Up, Back and Forward #11829)
• Navigate forward (RichCommands: Navigate Up, Back and Forward #11829)
• Navigate up (RichCommands: Navigate Up, Back and Forward #11829)
• Navigate To Next Tab (RichCommands: Switch tabs command #11916)
• - [x] Navigate To Previous Tab (RichCommands: Switch tabs command #11916)
• Open Directory In New Pane
• Open Directory In New Tab
• Open File Location
• Open In New Window Item
• Open In Terminal (Feature: Open in Terminal RichCommand #11445)
• Open Item (Feature: Add RichCommands Open, Open With, Open Parent Folder #11667)
• Open Item With Application Picker (Feature: Add RichCommands Open, Open With, Open Parent Folder #11667)
• Open New Tab (Rich command: NewTab + DuplicateTab #11596)
• Open Parent Folder (Feature: Add RichCommands Open, Open With, Open Parent Folder #11667)
• Open new pane (RichCommands: Open & Close Pane #12002)
• Open settings RichCommands: Open settings #11846
• Paste Items From Clipboard (Feature: RichCommands Cut/Copy/Paste #11670)
• Pin Directory To Favorite
• Play All (RichCommands: Redo/Undo & PlayAll #12017)
• Quick Look (RichCommand: QuickLook #11771)
• Redo (RichCommands: Redo/Undo & PlayAll #12017)
• Refresh RichCommand: Refresh items #11807
• Rename Item RichCommands: Rename #11861
• Reopen Tab (RichCommands: Reopen closed tabs #11833)
• Restore Item (Rich command: Context + Restore #11472)
• Restore Selection Recycle Bin (Rich command: Context + Restore #11472)
• Rotate Image Left (Rich Commands: Rotate image as Rich Commands #11633)
• Rotate Image Right (Rich Commands: Rotate image as Rich Commands #11633)
• Run As Admin (Feature: Add Run As Admin and Run As Another User RichCommands #11581)
• Run As Another User (Feature: Add Run As Admin and Run As Another User RichCommands #11581)
• Run With Powershell (RichCommand: Run With Powershell #11914)
• Search Unindexed Items (RichCommands: SearchUnindexedItems #12074)
• Select All (Feature: Add selection RichCommands #11502)
• Send to
• Set As Lockscreen Background (Code Quality: Rich commands Set As... #11563)
• Set As Slideshow Item(Code Quality: Rich commands Set As... #11563)
• Set as Desktop Background(Code Quality: Rich commands Set As... #11563)
• Show Folder Properties (RichCommand: Show Properties #11915)
• Show Properties (RichCommand: Show Properties #11915)
• Show/hide dot files
• Share file (RichCommand: ShareItem #11827)
• Sidebar Pin Item (Feature: Add RichCommand for pinning and unpinning items #11492)
• Sidebar Unpin Item (Feature: Add RichCommand for pinning and unpinning items #11492)
• Toggle Preview Pane (RichCommand: TogglePreviewPane #11578)
• Toggle Sidebar Rich Commands: Toggle sidebar #11847
• Undo (RichCommands: Redo/Undo & PlayAll #12017)
• Unpin Directory From Favorite
• Unpin Item From Start

Gains

• A more cohesive code.
• The ability to call commands easily from anywhere in the code.

Requirements

• Each of the commands previously cited have been transformed into Rich Commands.
• The previous implementations of the commands are cleaned up.

Comments

No response

[yaira2]

Thank you for putting this together!

[hecksmosis]

I'll do the sidebar pinned item ones

[hecksmosis]

I'm working on some of these slowly

[QuaintMako]

I'm tackling the 'Set As...' trio on my side.

[QuaintMako]

Once we're done with implementing all the commands, we'll need to remember to do a round of cleaning (regrouping the commands together, make sure they are stored inside the appropriate folders, make sure there is no leftovers from the former implementations etc...)

[hecksmosis]

Fyi, copy cut and delete heve already been implemented in #11504

[hishitetsu]

Gridview Size Decrease and Gridview Size Increase have already been implemented in #11678.

[cinqmilleans]

DuplicateTab/ Paste Items From Clipboard/(Pin/Unpin) Directory (To/From) (Favorites/Start) are implemented.
DragOver/Drop/Item Pointer Pressed must not be a command because they are only accessible by mouse (by nature).
A command to open the context menu would be handy.

[QuaintMako]

Thanks for the update @cinqmilleans, I need to go through the code in more details to check out what needs to be made as commands. I'll change the checklist with your information!

[yaira2]

Search Unindexed Items

Isn't this a setting? (perhaps we can add support for settings but let's limit the scope to regular actions)

[hecksmosis]

Shouldn't we make Close Tab a command?

[yaira2]

Shouldn't we make Close Tab a command?

Yes, with the ctrl + w shortcut.

[hecksmosis]

I'll look into open directory in new tab/Pane