RichCommand: QuickLook

[yaira2]

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Closes #issue...

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  1. Install and open QuickLook
  2. Open Files and select an item
  3. Press the space bar and see if the QuickLook preview opens
  4. Select a different item with the arrow keys or mouse and see if the preview updates
  5. Select multiple items and press the space bar, verify that the items remain selected.

Screenshots (optional)
Add screenshots here.

[yaira2]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[cinqmilleans]

There is a bug with the Space key. If you select an image file, then click on the search bar, you cannot use Space, it opens QuickLook. I will create another pr to fix this which is related to centralized hotkey management.

[yaira2]

There is a bug with the Space key. If you select an image file, then click on the search bar, you cannot use Space, it opens QuickLook. I will create another pr to fix this which is related to centralized hotkey management.

Does this affect the ctrl + a shortcut as well?

[cinqmilleans]

No because Ctrl+a/z/x/c/v was explicitly handled in MainPage (They are not triggered in a Textbox). You have to add only the keys, but not all of them (for example F11 can be triggered in a Textbox). You need an exhaustive list (white or black).

[cinqmilleans]

Regarding quicklook. While testing, I had the reflex to try to close it with the Escape key. Maybe add this hotkey to exit. (Command quit/exit, which can close active popup, settings, quicklook, properties,... ). It's another pr but I note the idea.

[yaira2]

Regarding quicklook. While testing, I had the reflex to try to close it with the Escape key. Maybe add this hotkey to exit. (Command quit/exit, which can close active popup, settings, quicklook, properties,... ). It's another pr but I note the idea.

Good idea 👍