Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Copy, Cut and Delete RichCommands #11504

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

hecksmosis
Copy link
Contributor

@hecksmosis hecksmosis commented Feb 28, 2023

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app

yaira2
yaira2 previously approved these changes Feb 28, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 28, 2023
@yaira2
Copy link
Member

yaira2 commented Feb 28, 2023

Thank you

@cinqmilleans
Copy link
Contributor

A few comments.

  • Completely remove the commands from the ToolbarViewModel, and use the commands in the xaml.
  • Implement IsExecutable (observable) to avoid having to handle it in the xaml.

@hecksmosis
Copy link
Contributor Author

Oh ok, I think I'm going to open anew pr when this is merged and do this for all the other richcommands that got implemented without IsExecutable

@yaira2 yaira2 merged commit 2c5963c into files-community:main Feb 28, 2023
@yaira2
Copy link
Member

yaira2 commented Mar 1, 2023

Looks like these commands are showing as secondary items instead of primary items.

@hecksmosis hecksmosis mentioned this pull request Mar 10, 2023
78 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants