Feature: Implement more RichCommands #11493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
added
the
ready to merge
78 tasks
yaira2
reviewed
Mar 1, 2023
| }, | ||
| Command = commandsViewModel.CreateShortcutCommand, | ||
| ShowItem = itemsSelected && (!selectedItems.FirstOrDefault()?.IsShortcut ?? false), | ||
| SingleItemOnly = true, |
There was a problem hiding this comment.
Just noticed this was removed, create shortcut should only show if a single item is selected.
yaira2
reviewed
Mar 1, 2023
| OpacityIconStyle = "ColorIconPinToFavorites", | ||
| }, | ||
| Command = commandsViewModel.PinItemToStartCommand, | ||
| ShowOnShift = true, |
There was a problem hiding this comment.
Looks like show on shift was also removed, can you add this back?
yaira2
reviewed
Mar 1, 2023
| OpacityIconStyle = "ColorIconUnpinFromFavorites", | ||
| }, | ||
| Command = commandsViewModel.UnpinItemFromStartCommand, | ||
| ShowOnShift = true, |
yaira2
reviewed
Mar 1, 2023
| ShowItem = selectedItems.All(x => !x.IsShortcut && (x.PrimaryItemAttribute == StorageItemTypes.Folder || x.IsExecutable) && !x.IsArchive && !x.IsItemPinnedToStart), | ||
| ShowInSearchPage = true, | ||
| ShowInFtpPage = true, | ||
| SingleItemOnly = true, |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Items resolved / related issues by this PR.
Validation
How did you test these changes?