Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed issue where unpin from start didn't work #12193

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Fix: Fixed issue where unpin from start didn't work #12193

merged 1 commit into from
Apr 28, 2023

Conversation

marcofranzen99
Copy link
Contributor

Description
The UnpinFromStartAction calls currently the TryPinFolderAsync instead of the UnpinFromStartAsync method.
The bug was introduced in #11493 where the code was migrated to a RichCommand.

With this change it is again possible to unpin items from the start menu.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Unpin a single file
    2. Unpin multiple files
    3. Unpin single directory
    4. Unpin multiple directories

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title Fix: Unpin from start does not work Fix: Fixed issue where unpin from start didn't work Apr 25, 2023
@hishitetsu hishitetsu mentioned this pull request Apr 25, 2023
Merged
8 tasks
yaira2
yaira2 approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 28, 2023
@yaira2 yaira2 merged commit c4a6dbe into files-community:main Apr 28, 2023
hishitetsu pushed a commit to hishitetsu/Files that referenced this pull request Apr 30, 2023
@marcofranzen99 @hishitetsu
Fix: Fixed issue where unpin from start didn't work (files-community#…
8bc1d45 
…12193)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcofranzen99 @yaira2