Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: RichCommands Cut/Copy/Paste #11670

Closed

Conversation

cinqmilleans
Copy link
Contributor

Resolved / Related Issues

  • New rich command PasteItem.
  • Fix visibility of private methods.
  • The Paste command is inconsistent. In the context menu, the selection must be empty or a single folder of type element. In the toolbar, if there are several elements selected, we copy to the parent folder. Now Paste is always disabled if the selection is more than one item or the item is not a folder.
  • The Paste AccessKey is now V instead P. This corresponds to Cut(X) and Copy(C). This adds the accessKey P to the PreviewPane if need.
  • Use commands Cut/Copy/Paste in the context menu.
  • Paste is always visible in the context menu, It's more intuitive. It was visible in search results (useless) but not in RecycleBin. It was visible in search results (useless) but not in trash. Now Cut/Copy/Paste go together with less chance of getting it wrong.
  • Fix the new text Cut.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@QuaintMako QuaintMako mentioned this pull request Mar 11, 2023
78 tasks
@yaira2 yaira2 changed the title Commands Cut/Copy/Paste, Yes again. Feature: RichCommands Cut/Copy/Paste Mar 12, 2023
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Mar 12, 2023
@yaira2 yaira2 added needs - code review and removed changes requested Changes are needed for this pull request labels Mar 12, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 14, 2023
@yaira2
Copy link
Member

yaira2 commented Mar 14, 2023

@cinqmilleans can you fix the build error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants