RichCommands: Open & Close Pane

[ferrariofilippo]

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Related Generalizing Rich Command Usage #11481
  Closes Bug: Starting dual-pane mode raises a NotAFolder error in other than English #12016

Notes
I had to change an hotkey of OpenNewPane (Alt + Shift + Add -> Ctrl + Shift + Add) since there's a conflict with an external shortcut (if you hit Alt + Add SearchBox will be focused).
I searched through all the source code but there's no conflict in it (SearchAction is not executed). The stacktrace shows that the event is raised by ExternalCode.
THIS ISSUE IS NOT RELATED WITH #11837 (Existed even before that commit)

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  1. Open app
  2. Use toolbar commands or shortcuts to open and close panes

[QuaintMako]

LGTM.

Regarding the change of the shortcut, when the PR is merged, the shortcut on the website documentation will need to be refreshed.

[yaira2]

I had to change an hotkey of OpenNewPane (Alt + Shift + Add -> Ctrl + Shift + Add) since there's a conflict with an external shortcut (if you hit Alt + Add SearchBox will be focused).

I can't reproduce this issue

[ferrariofilippo]

Maybe it depends on windows language or some other windows setting 🤔
If I'm the only one having this issue I'll change back the shortcut