-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Concurrent Mode] Add missing event plugin priorities #17914
Merged
trueadm
merged 1 commit into
facebook:master
from
trueadm:add-priorities-for-event-types
Jan 28, 2020
Merged
[Concurrent Mode] Add missing event plugin priorities #17914
trueadm
merged 1 commit into
facebook:master
from
trueadm:add-priorities-for-event-types
Jan 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
requested review from
threepointone,
bvaughn,
sebmarkbage,
necolas,
gaearon,
lunaruan and
acdlite
January 27, 2020 15:06
facebook-github-bot
added
CLA Signed
React Core Team
Opened by a member of the React Core Team
labels
Jan 27, 2020
threepointone
approved these changes
Jan 27, 2020
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e9e5cb8:
|
Details of bundled changes.Comparing: e26682a...e9e5cb8 react-dom
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (experimental) |
Details of bundled changes.Comparing: e26682a...e9e5cb8 react-dom
ReactDOM: size: 🔺+0.1%, gzip: 🔺+0.1% Size changes (stable) |
trueadm
force-pushed
the
add-priorities-for-event-types
branch
from
January 27, 2020 16:44
85e4de5
to
2fe49ed
Compare
trueadm
force-pushed
the
add-priorities-for-event-types
branch
from
January 28, 2020 12:11
2fe49ed
to
e9e5cb8
Compare
Merged
This was referenced Mar 6, 2020
This was referenced Sep 25, 2024
This was referenced Sep 28, 2024
This was referenced Sep 29, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
This was referenced Oct 12, 2024
This was referenced Oct 25, 2024
This was referenced Oct 26, 2024
This was referenced Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are missing some explicit event priorties (all discrete) that are used for event plugin types. This PR adds them and their priorities so they're probably handled in Concurrent Mode. Previously, these events were missing, so their priority would default to Continious priortiy. This would be hard to observe as these events are typically used in polyfill situations where better events are either not supported well or are missing (IE etc); thus the liklihood of running into issues with Concurrent Mode would be unlikely.