Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable shorthand CSS property collision warning #18002

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Re-enable shorthand CSS property collision warning #18002

merged 1 commit into from
Feb 10, 2020

Conversation

sophiebits
Copy link
Collaborator

@sophiebits sophiebits commented Feb 8, 2020 •
edited
Loading

Originally added in #14181; disabled in #14245. Intention was to enable it in React 16.7 but we forgot.

Fixes #16393.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 8, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9010d93:

Sandbox Source
nice-cloud-otcbd Configuration
React example Issue #16393

@sizebot
Copy link

sizebot commented Feb 8, 2020 •
edited
Loading

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 9010d93

@sizebot
Copy link

sizebot commented Feb 8, 2020 •
edited
Loading

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 9010d93

threepointone
threepointone approved these changes Feb 9, 2020
View reviewed changes
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also rename ReactDOMShorthandCSSPropertyCollision-test.internal.js > ReactDOMShorthandCSSPropertyCollision-test.js. Thanks!

@sophiebits
Re-enable shorthand CSS property collision warning
9010d93 
Originally added in facebook#14181; disabled in facebook#14245. Intention was to enable it in React 16.7 but we forgot.
@sophiebits
Copy link
Collaborator Author

Renamed the test and removed the feature flag from it.

@threepointone threepointone merged commit 4f71f25 into facebook:master Feb 10, 2020
@threepointone threepointone mentioned this pull request Feb 25, 2020
Merged
@craigkovatch
Copy link

Three cheers for @sophiebits !!!

@yowainwright yowainwright mentioned this pull request Mar 6, 2020
Open
This was referenced Mar 6, 2020
Closed
Merged
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2024
Open
Open
This was referenced Sep 28, 2024
Open
Open
This was referenced Sep 29, 2024
Open
Open
This was referenced Oct 3, 2024
Open
Open
@brandonyee333 brandonyee333 mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 4, 2024
Open
Open
Open
Open
@lgdd lgdd mentioned this pull request Oct 5, 2024
Open
This was referenced Oct 5, 2024
Open
Open
This was referenced Oct 12, 2024
Open
Open
This was referenced Oct 25, 2024
Open
Open
Open
Open
This was referenced Oct 26, 2024
Open
Open
This was referenced Oct 27, 2024
Open
Open
@topolik topolik mentioned this pull request Oct 30, 2024
Open
This was referenced Nov 4, 2024
Open
Open
@snyk-kevin snyk-kevin mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threepointone threepointone threepointone approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shorthand CSS property collision should trigger a warning
5 participants
@sophiebits @sizebot @craigkovatch @threepointone @facebook-github-bot