[Bugfix] Pending state is always user-blocking #17382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where `isPending` is only set to `true` if `startTransition` is called from inside an input event. That's usually the case, but not always. Now it works regardless of where you call it.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c292c83:
|
|
Btw we track this in #17272 |
lunaruan
approved these changes
Nov 15, 2019
sebmarkbage
reviewed
Nov 15, 2019
| }, | ||
| [value, config], | ||
| ); | ||
| return prevValue; | ||
| } | ||
|
|
||
| function startTransition(setPending, config, callback) { | ||
| const priorityLevel = getCurrentPriorityLevel(); | ||
| runWithPriority( |
There was a problem hiding this comment.
I feel like we do this in a couple of internal places which seems like a very heavy weight way to do this. Going through the scheduler to do this. This adds to my suspicion that reading priorities from scheduler is the wrong model. It's not that scheduler dictates the priorities but it sometimes can be used as a default.
There was a problem hiding this comment.
I agree, it's on my list of things to consider during expiration times refactor. Didn't want to couple it to this bugfix.
| }, | ||
| ); | ||
| runWithPriority( | ||
| priorityLevel > NormalPriority ? NormalPriority : priorityLevel, |
There was a problem hiding this comment.
Similarly here, it's not obvious to me that calling startTransition should change the running "current" queue of the scheduler. It should only change the priority inside React. They're not necessarily 1:1.
gaearon
reviewed
Nov 16, 2019
| let useTransition; | ||
| let act; | ||
|
|
||
| describe('ReactHooksWithNoopRenderer', () => { |
Details of bundled changes.Comparing: 8e74a31...c292c83 react-native-renderer
Size changes (stable) |
Details of bundled changes.Comparing: 8e74a31...c292c83 react-native-renderer
react-art
react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (experimental) |
Merged
This was referenced Mar 6, 2020
This was referenced Sep 25, 2024
This was referenced Sep 28, 2024
This was referenced Sep 29, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
This was referenced Oct 12, 2024
This was referenced Oct 25, 2024
This was referenced Oct 26, 2024
This was referenced Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where
isPendingis only set totrueifstartTransitionis called from inside an input event. That's usually the case, but not always.Now it works regardless of where you call it.
Fixes #17272