Don't group Idle/Offscreen work with other work #17456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b1645e0:
|
Details of bundled changes.Comparing: f523b2e...b1645e0 react-native-renderer
react-test-renderer
react-art
react-dom
react-reconciler
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (experimental) |
Details of bundled changes.Comparing: f523b2e...b1645e0 react-art
react-native-renderer
react-test-renderer
Size changes (stable) |
|
I think we’ll also have to do something about |
acdlite
reviewed
Nov 26, 2019
sebmarkbage
force-pushed
the
trainmodel
branch
2 times, most recently
from
b70609d
to
e576ea1
Compare
sebmarkbage
commented
Dec 3, 2019
| nextLevel <= Idle && | ||
| firstPendingTime !== nextLevel | ||
| ) { | ||
| // Don't work on Idle/Never priority unless everything else is committed. |
There was a problem hiding this comment.
I'm a bit uneasy about this since if something goes wrong, it's not possible to unblock by pinging these levels. However, I don't think it ever happens now because these levels wouldn't ever be suspended if something else rendered at higher pri because that makes them unsuspended. I couldn't make a test that fails.
sebmarkbage
force-pushed
the
trainmodel
branch
from
e576ea1
to
2266225
Compare
When we suspend we always try a lower level but we shouldn't try offscreen.
sebmarkbage
force-pushed
the
trainmodel
branch
from
2266225
to
b1645e0
Compare
trueadm
pushed a commit
to trueadm/react
that referenced
this pull request
Dec 4, 2019
When we suspend we always try a lower level but we shouldn't try offscreen.
trueadm
pushed a commit
to trueadm/react
that referenced
this pull request
Dec 4, 2019
When we suspend we always try a lower level but we shouldn't try offscreen.
Merged
This was referenced Mar 6, 2020
This was referenced Sep 25, 2024
This was referenced Sep 28, 2024
This was referenced Sep 29, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
This was referenced Oct 12, 2024
This was referenced Oct 25, 2024
This was referenced Oct 26, 2024
This was referenced Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we suspend we always try a lower level but we shouldn't try offscreen.
If nothing pings during this time then we’ll never return back to rendering the smaller set. This leads us to overrender a lot and assume offscreen heuristics for visible content.
Offscreen really shouldn’t ever render unless we’ve committed everything else. There’s no reason to since hidden and hydrating work never unblocks anything.
This change makes it so we leave cpu cycles on the table. Ideally we could warm up hidden work and then return to the previously prepared tree but since we can’t do that yet it’s better to not throw away the tree.