…o feat/net5upgrade

…o feat/net5upgrade

* breaking upgrade base build image to net5.0

* add make and build tools to image

* fix code broken after net5.0 upgrade

* fix warnings

* fix tests and line endings

* upgrade dotnet test and coverages packages

* update circle build image

* removed rafty and updated more packages

* bring back develop

* rename authorisation to authorization

* upgrade csproj to net5.0

* add make and build tools to image

* fix code broken after net5.0 upgrade

* update circle build image

* removed rafty and updated more packages

* all packages upgraded and tests passing

* bring back develop

* rename authorisation to authorization

* +semver: major upgrading from net5.0 to net6.0

* packages upgraded

* removed global.json for ocelot sf sample

* update build image

* test new build

* remove make

* fix tests

* make test fail like in CI

* tests passing locally

* updated docs


Co-authored-by: TGP <[email protected]>

* tests passing on debian 10

* how to generate test cert

* updated build image to include git

* updated build image to include openssh-client

* updated report generator

* report working

* Add StyleCop.Analyzers package

* Fix SA0001: XML comment analysis is disabled due to project configuration

* Fix SA1609: Property documentation should have value

* Fix CS1591: Missing XML comment for publicly visible type or member {xyz}

* Fix SA1101: Prefix local calls with this

* Fix SA1413: The last statement in a multi-line C# initializer or list is missing a trailing comma.

* Fix SA1135: A using directive is not qualified.

* Fix compiler errors

* Fix SA1651: Do not use placeholder elements

* Fix compiling error

* Fix SA1113: Comma should be on the same line as previous parameter

* Fix SA1116: The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines

* Fix SA1137: Elements should have the same indentation

* Fix SA1200: Using directive should appear within a namespace declaration

* Fix SA1316: Tuple element names should use correct casing

* Fix SA1503: Braces should not be omitted

* Fix SA1505: An opening brace should not be followed by a blank line

* Fix SA1507: Code should not contain multiple blank lines in a row

* Fix SA1508: A closing brace should not be preceded by a blank line

* Fix SA1512, SA1515

* Fix SA1513: Closing brace should be followed by blank line

* Fix SA1400: Element 'OpenTracingTracer' should declare an access modifier

* Fix SA1515: Single-line comment should be preceded by blank line

* Fix SA1518: File is required to end with a single newline character

* Add StyleCop

* Fix SA1633: A C# code file is missing a standard file header.

* Disable SA1602: An item within a C# enumeration is missing an Xml documentation header.

* Fix SA1600: Elements should be documented

* Fix SA1604: Element documentation should have summary

* Fix SA1618: The documentation for type parameter 'T' is missing

* Fix SA1629: Documentation text should end with a period.

* Fix SA1649: File name should match first type name

* Fix SA1600: Elements should be documented

* Upgrade K8s sample to ASP.NET 7.
Rename project to Ocelot.Samples.OcelotKube.DownstreamService

* Upgrade K8s sample to ASP.NET 7.
Rename project to Ocelot.Samples.OcelotKube.ApiGateway

* Fix CS0169: The field 'xxx' is never used

* Fix CS0219: The variable 'baseUrl' is assigned but its value is never used

* Fix CS0414: The field 'xxx' is assigned but its value is never used

* Fix CS1570: XML comment has badly formed XML

* Fix CS0649: Field 'xxx' is never assigned to, and will always have its default value null

* Fix CS0618: 'member' is obsolete: 'text'

* Fix NU1504: Duplicate 'PackageReference' items found: Microsoft.Data.SQLite 7.0.4, Microsoft.Data.SQLite 7.0.5

* Upgrade sample to ASP.NET 7

* Fix NU5048: The 'PackageIconUrl'/'iconUrl' element is deprecated.
Consider using the 'PackageIcon'/'icon' element instead.
Learn more at https://aka.ms/deprecateIconUrl

* Rewrite a RequestDelegate object definition

* Fix CS0618: 'member' is obsolete: 'text'

* Fix CA1816: Change Dispose() to call GC.SuppressFinalize(object).
This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it.

* Fix CA1822: Member 'GivenThereIsAConfiguration' does not access instance data and can be marked as static

* Fix CA1837: Use 'Environment.ProcessId' instead of 'Process.GetCurrentProcess().Id'

* Fix CA2211: Non-constant fields should not be visible.
Convert to property.

* Fix IDE0060: Remove unused parameter 'path' if it is not part of a shipped public API

* Fix CA1816: Change ConsulWebSocketTests.Dispose() to call GC.SuppressFinalize(object).

* Fix IDE1006: Naming rule violation: These words must begin with upper case characters

* Fix IDE1006: Naming rule violation: These words must begin with upper case characters: AcceptanceTests\WebSocketTests

* Fix last issues

* Upgrade basic sample to ASP.NET 7

Co-authored-by: Justin Middler <[email protected]>

* push code coverage for main and develop branches

* #1660 Huge logs because of StyleCop.Analyzers warnings (#1663)

* Add StyleCop.Analyzers package

* Fix SA0001: XML comment analysis is disabled due to project configuration

* Fix SA1609: Property documentation should have value

* Fix CS1591: Missing XML comment for publicly visible type or member {xyz}

* Fix SA1101: Prefix local calls with this

* Fix SA1413: The last statement in a multi-line C# initializer or list is missing a trailing comma.

* Fix SA1135: A using directive is not qualified.

* Fix compiler errors

* Fix SA1651: Do not use placeholder elements

* Fix compiling error

* Fix SA1113: Comma should be on the same line as previous parameter

* Fix SA1116: The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines

* Fix SA1137: Elements should have the same indentation

* Fix SA1200: Using directive should appear within a namespace declaration

* Fix SA1316: Tuple element names should use correct casing

* Fix SA1503: Braces should not be omitted

* Fix SA1505: An opening brace should not be followed by a blank line

* Fix SA1507: Code should not contain multiple blank lines in a row

* Fix SA1508: A closing brace should not be preceded by a blank line

* Fix SA1512, SA1515

* Fix SA1513: Closing brace should be followed by blank line

* Fix SA1400: Element 'OpenTracingTracer' should declare an access modifier

* Fix SA1515: Single-line comment should be preceded by blank line

* Fix SA1518: File is required to end with a single newline character

* Add StyleCop

* Fix SA1633: A C# code file is missing a standard file header.

* Disable SA1602: An item within a C# enumeration is missing an Xml documentation header.

* Fix SA1600: Elements should be documented

* Fix SA1604: Element documentation should have summary

* Fix SA1618: The documentation for type parameter 'T' is missing

* Fix SA1629: Documentation text should end with a period.

* Fix SA1649: File name should match first type name

* Fix SA1600: Elements should be documented

* Upgrade K8s sample to ASP.NET 7.
Rename project to Ocelot.Samples.OcelotKube.DownstreamService

* Upgrade K8s sample to ASP.NET 7.
Rename project to Ocelot.Samples.OcelotKube.ApiGateway

* Fix CS0169: The field 'xxx' is never used

* Fix CS0219: The variable 'baseUrl' is assigned but its value is never used

* Fix CS0414: The field 'xxx' is assigned but its value is never used

* Fix CS1570: XML comment has badly formed XML

* Fix CS0649: Field 'xxx' is never assigned to, and will always have its default value null

* Fix CS0618: 'member' is obsolete: 'text'

* Fix NU1504: Duplicate 'PackageReference' items found: Microsoft.Data.SQLite 7.0.4, Microsoft.Data.SQLite 7.0.5

* Upgrade sample to ASP.NET 7

* Fix NU5048: The 'PackageIconUrl'/'iconUrl' element is deprecated.
Consider using the 'PackageIcon'/'icon' element instead.
Learn more at https://aka.ms/deprecateIconUrl

* Rewrite a RequestDelegate object definition

* Fix CS0618: 'member' is obsolete: 'text'

* Fix CA1816: Change Dispose() to call GC.SuppressFinalize(object).
This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it.

* Fix CA1822: Member 'GivenThereIsAConfiguration' does not access instance data and can be marked as static

* Fix CA1837: Use 'Environment.ProcessId' instead of 'Process.GetCurrentProcess().Id'

* Fix CA2211: Non-constant fields should not be visible.
Convert to property.

* Fix IDE0060: Remove unused parameter 'path' if it is not part of a shipped public API

* Fix CA1816: Change ConsulWebSocketTests.Dispose() to call GC.SuppressFinalize(object).

* Fix IDE1006: Naming rule violation: These words must begin with upper case characters

* Fix IDE1006: Naming rule violation: These words must begin with upper case characters: AcceptanceTests\WebSocketTests

* Fix last issues

* Upgrade basic sample to ASP.NET 7

* fixed up required spacing in README (#1499)

Co-authored-by: Justin Middler <[email protected]>

* Update README.md

---------

Co-authored-by: TomPallister <[email protected]>
Co-authored-by: Justin Middler <[email protected]>
Co-authored-by: Justin Middler <[email protected]>
Co-authored-by: Tom Pallister <[email protected]>

Technical delivery of top features in develop

Sync develop to main

* Fix typo in class and file name
"Exeption" -> "Exception"

* And rename the test

* IDE1006 Naming rule violation: These words must begin with upper case characters: {should_*}
Fix name violation

---------

Co-authored-by: Anthony Steele <[email protected]>
Co-authored-by: raman-m <[email protected]>

* Fixing an issue where only setting timeout value in QoS would result in a exception getting thrown. Issue #908

* Apply wrapping in case of two policies or more

* Enable unit testing using DI pattern

* Add unit tests for the PollyCircuitBreakingDelegatingHandler class

* Split using sections for Ocelot.* and System.* namespaces

* Fix code review issue: "more than 1"

* File-scoped namespace

* Fix messages

* IDE1006 Naming rule violation: These words must begin with upper case characters

* IDE0062 Local function can be made static

* IDE1006 Naming rule violation: These words must begin with upper case characters: should_*

* Remove and Sort Usings

* Remove and Sort Usings

* RaynaldM code review

---------

Co-authored-by: Raman Maksimchuk <[email protected]>

* fixed typo in log

* Update OutputCacheMiddleware.cs

* Update OutputCacheMiddleware.cs

* Fix typos and improve logger messages for OutputCacheMiddleware

---------

Co-authored-by: PLTHLOU <[email protected]>
Co-authored-by: Raman Maksimchuk <[email protected]>
Co-authored-by: Raman Maksimchuk <[email protected]>

Co-authored-by: Raman Maksimchuk <[email protected]>

* fix char missing when query string contains the placeholder name and value

* fix the regex problem with removing a query param when it is not the first

* Remove and Sort Usings

* CA1845 Use span-based 'string.Concat' and 'AsSpan' instead of 'Substring'

* IDE0057 Substring can be simplified.
Use range operator

* IDE0057 Substring can be simplified.
Use range operator

* IDE0042 Variable declaration can be deconstructed.
Deconstruct variable declaration

---------

Co-authored-by: raman-m <[email protected]>

* log Consul querying and the answers

* Code review: Fix long expressions

* Remove and Sort Usings

* Use expression body

* Right order of initialization sentances

---------

Co-authored-by: raman-m <[email protected]>

* #893 fix request cancellation, add acceptance test

* correct exception message

* correct exception message

* #893 fix request cancellation, add acceptance test

* correct exception message

* correct exception message

* Add more conditions in Then criteria

* Update MultiplexingMiddleware.cs

* Update CancelRequestTests.cs

* Fix StyleCop and IDE analyzers issues

* 'using' workarounds

* Convert to file-scoped namespace

* Fix warnings

* IDE0044 Make field readonly. Add readonly modifier

* review the code

---------

Co-authored-by: Raman Maksimchuk <[email protected]>
Co-authored-by: Raman Maksimchuk <[email protected]>

…ration construction (#1569)

* Added AddOcelot Configbuilder Overload

Added an AddOcelot overload to load FileConfiguration directly from the application, so that all the routes could be made configurable and could be load from anywhere.

* Code review changes

* Added unit tests for ConfigurationBuilder AddOcelot method overload

* code review

* CA1816 Change ConfigurationReloadTests.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it.

* SYSLIB1045 Use 'GeneratedRegexAttribute' to generate the regular expression implementation at compile-time.

* SA1601 Partial elements should be documented

* Add developer's XML-docs

---------

Co-authored-by: raman-m <[email protected]>

…peline building via the IMvcCoreBuilder interface (#1655)

* AddOcelot support custom mvc builder.

* Fix SA1503 : The opening and closing braces for a C# statement have been omitted.

* Fix SA1135 : A using directive is not qualified.

* Add AddDefaultAspNetServices method. Remove anonymous delegate.

* Make method names shorter

* add unit test for AddOcelotUsingBuilder

* Sort Usings

* Refactor integration test for the case with AddOcelotUsingBuilder

* Update OcelotBuilder.cs

* Update gettingstarted.rst

Fix target framework as net7.0

* Add "The AddOcelot method" paragraph

* Use correct heading levels for subsections

* Update configuration.rst

Use correct heading levels for (sub)sections

* Update configuration.rst

Readability improvements

* Incapsulate all system services to the AddDefaultAspNetServices method

* Add developer's XML-docs for OcelotBuilder and related extensions

* Create dependencyinjection.rst

* Update dependencyinjection.rst

Overview paragraph

* Update dependencyinjection.rst

"IServiceCollection extensions" paragraph.
"The OcelotBuilder class" paragraph.

* Update dependencyinjection.rst: Custom Builder paragraph

* Add Dependency Injection feature to the index of docs

* Update gettingstarted.rst: Add footnotes

* Correction of typo in English grammar

* Unit tests for AddOcelotUsingBuilder extension

* Improve readability of BDDfy scenarios in logs

* Update requestaggregation.rst. Add footnotes 

Mark down corrections

* Update tracing.rst: Add footnotes. Markdown text corrections

* Update qualityofservice.rst: Add footnotes

* Update administration.rst: Add footnotes. Markdown text corrections

* Update configuration.rst: Add footnotes. Text corrections

* IDE1006 Naming rule violation: These words must begin with upper case characters: should_*

---------

Co-authored-by: Raman Maksimchuk <[email protected]>

* #1676 Update authorization.rst

* #1646 Update bigpicture.rst

* #1628 Update websockets.rst

* #1614 Update README.md

* #1552 Update configuration.rst

* #1547 Update caching.rst

* #1542 Update requestaggregation.rst

* Revert "#1639 Update ClientRateLimitMiddleware.cs"

This reverts commit 996719e.

* #1537 Update routing.rst

* #1520 Update authentication.rst

* #1459 Update building.rst

Fix inline code block

* #1412 Update errorcodes.rst

* #1407 Update headerstransformation.rst

* #1406 Update headerstransformation.rst

Remove extra '!'

* #1320 Update README.md

* Update README.md

Mark classes. Split sentences.

* #1284 Update claimstransformation.rst

* #1232 Update servicediscovery.rst

* #1224 Update loadbalancer.rst

* #1189 Update caching.rst

* Update gettingstarted.rst

Mark up 'net7.0' as code block. Convert script block to PowerShell one. Change the link to NuGet.

* #1386 Update loadbalancer.rst

* Update loadbalancer.rst: Make code snippet shorter

* #1686 Update middlewareinjection.rst

Add section "ASP.NET Core Middlewares and Ocelot Pipeline Builder"

* Update logging.rst

Review RST markup

* Update methodtransformation.rst

Review RST markup

* Update README.md

Sync to "Big Picture" page in Introduction

…g parallel execution (#1703)

* When instantiating steps, creating a custom ocelot config file name. Finally deleting the newly created config file when disposing the Step instance.

* Removing DeleteOcelotConfig from GivenThereIsAConfiguration, since File.WriteAllText will overwrite the file.

* using xunit.runner.json it's getting on my nerves

* Trying yet another strategy

* Revert "using xunit.runner.json it's getting on my nerves"

This reverts commit 9fac778.

* Not sure about GC.SuppressFinalize here

* correct usage of Wait.WaitFor...

* Do we really need to get a random port? Wouldn't be enough to get the next available port? Adding lock for thread safety

* Updating duration of break in Open_circuit_should_not_effect_different_routes from 1000 ms to 1500 ms

* ConfigurationReloadTests as sealed class

* moving variables initializations to Steps constructor

* putting back during of break to 1000, out of scope of current PR

* Code review

---------

Co-authored-by: raman-m <[email protected]>

* Add sequential tests with disabled parallelization

* samples

* Ocelot

* Ocelot.*

* tests

* Add ImplicitUsings property to the projects (C# 10)

* Upgrade xUnit setup in test projects

* Add global usings

* Remove Unnecessary Usings.
IDE0005: Using directive is unnecessary.

* IDE0001: Name can be simplified.
Remove 'global::' prefix

* IDE0005: Using directive is unnecessary.
Remove and Sort Usings

* IDE0005: Using directive is unnecessary.
Remove Unnecessary Usings

* Disable implicit usings

* Add required usings

* Global usings

* Add required namespace

…tificateValidator (#1377)

* Fix/1375 fix DownstreamRoute DangerousAcceptAnyServerCertificateValidator does not work

* Fix the exception when RoundRobin services is empty

* Fix build errors

* IDE0063 'using' statement can be simplified

* IDE0051 Private member 'StreamCopyBufferSize' is unused

* Use nameof() in string interpolations

* @RaynaldM code review

* Code review. Refactor method

* Organize folders for WebSockets feature

* Add unit tests class for WebSockets feature

* Refactor middleware to make it suitable for unit testing

* Add unit test

* Review current acceptance tests for WebSockets

* Review

---------

Co-authored-by: raman-m <[email protected]>

…stom Providers (#1656)

* Update servicediscovery documentation to include custom provider

* Update servicediscovery.rst

Custom Providers paragraph

* Update servicediscovery.rst

Fix lower/upper case in paragraph name

* Added custom service provider sample

* Minor clarification to custom service discovery provider docs

* Move usings to the top. Use file-scoped namespace declaration

* Moved custom service discovery sample
Added sample to Ocelot.sln

* Added custom service provider sample

* Move usings to the top. Use file-scoped namespace declaration

* Moved custom service discovery sample
Added sample to Ocelot.sln

* Add 2 options/ways of solution development via ConfigureServices

* Upgrade DownstreamService to ASP.NET 7

* Upgrade ApiGateway to ASP.NET 7

* Update README.md

* Removed redundant spring section in config
Move urls config from Program.cs to appsettings.json

* Workaround for the Categories route

* Rename controller: class name should be the same as file name

* Upgrade to Web API app: multiple startup profiles, add Docker profile. Basic microservices template

* Correct registration of IServiceDiscoveryProviderFactory interface

* Update README.md: Fix upstream path because of case sensitivity

* Update servicediscovery.rst: Update Custom Providers section. Add sample solution.

* Update servicediscovery.rst: Update actual code from the sample

* Remove obsolete code

* CS8632 The annotation for nullable reference types should only be used in code within a '#nullable' annotations context

* Revert to previous state

* Revert back to the version from ThreeMammals:develop

* Update servicediscovery.rst: English checking

---------

Co-authored-by: raman-m <[email protected]>

…SocketsProxyMiddleware (#1689)

* Update WebSocketsProxyMiddleware.cs

Fix WebSocket for SignalR

* Repalce url protocol after null check

* small refactoring

* Add error log when replacing protocol in WebSocketProxyMiddleware

Co-authored-by: Raman Maksimchuk <[email protected]>

* Fix build

* Code review

* Fix unit test

* Refactor to remove hardcoded strings of schemes

* Define public constants

* Add unit tests

---------

Co-authored-by: raman-m <[email protected]>

…ements and fix errors (#1670)

* fixing some issues in poll consul:
- Timer is not thread safe, avoiding usage of it
- No Ressources are returned for first call
- Using a providers pool, instead of creating a new provider instance

* line endings

* adding some test cases

* Using a lock instead of SemaphoreSlim

* Improve code readability

* CA2211: Non-constant fields should not be visible

* Use IOcelotLogger to remove warnings & messages of static code analysis (aka IDE0052)

* Fix errors with unit tests discovery. Remove legacy life hacks of discovering tests on .NET Core

* Update unit tests

* Also refactoring the kubernetes provider factory (like consul and eureka)

* shorten references...

* const before...

* Some minor fixes, using Equals Ordinal ignore case and a string constant for provider type definition instead of string litterals. Fixing usings.

* waiting a bit longer then?

* @RaynaldM code review

* renaming PollKubernetes to PollKube

* ... odd...

* ... very odd, we have an issue with configuration update duration...

* IDE0002: Name can be simplified

* All tests passing locally, hopefully it works online

* just a bit of cleanup

* Some missing braces and commas

* Update servicediscovery.rst: Review and update "Consul" section

---------

Co-authored-by: Guillaume Gnaegi <[email protected]>
Co-authored-by: raman-m <[email protected]>

* Ignore port when using UpstreamHost option

* Update src/Ocelot/DownstreamRouteFinder/Middleware/DownstreamRouteFinderMiddleware.cs

---------

Co-authored-by: Raman Maksimchuk <[email protected]>

…ptions config section (#1399)

* Add IpAddressRange package and manage multiple pattern in order to allow or block ip addresses

* Update SecurityOptions.cs

* Update FileSecurityOptions.cs

* Fix Issues

* Update routing.rst

Fix typos and mistakes in the Security Options paragraph

* Update FileSecurityOptions.cs

Add developer's XML docs with description from #1400

* Update configuration.rst

* Update docs with License Reference

* SecurityOptions init moved to SecurityOptionsCreator

* Update unit test

* SecurityOptionsCreator: File-scoped namespace declaration

* Fix SA1312: Variable 'xxx' should begin with lower-case letter

* Remove using alias and make logical reference to the package

* Fix SA1609: Property documentation should have value

* FileSecurityOptions: File-scoped namespace declaration

* Fix SA1135: Using directive for namespace 'Ocelot.Responses' should be qualified.
Sort usings.
Convert to file-scoped namespace.

* Fix test code style

* Refactor SecurityOptions

* FileSecurityOptions: Add constructors

* Refactor SecurityOptions: Add constructors

* Using constructors for SecurityOptions creation, not initialization

* Fix unit test after latest infrastructure updates

* Convert to block scoped namespace

* Update IPAddressRange to v.6.0.0

* Update src/Ocelot/Configuration/Creator/SecurityOptionsCreator.cs

Co-authored-by: Raynald Messié <[email protected]>

* Revert "Update src/Ocelot/Configuration/Creator/SecurityOptionsCreator.cs"

This reverts commit a77a30e.

* Update comment con IPAddressRange reference

* Use Select<IPAddress, string> instead of AsEnumerable

* Remove and Sort Usings

---------

Co-authored-by: Fabrizio Mancin <[email protected]>
Co-authored-by: Raman Maksimchuk <[email protected]>
Co-authored-by: Raman Maksimchuk <[email protected]>
Co-authored-by: Raynald Messié <[email protected]>

…#1424)

* Update HeaderFindAndReplaceCreator.cs

Second parameter of Substring was wrong. Existing implementation works only for replacements at the beginning of a string (startOfPlaceholder = 0)

* Update HeaderFindAndReplaceCreator.cs

Remove and Sort Usings

* Update HeaderFindAndReplaceCreator.cs: Replace by char

Co-authored-by: Raynald Messié <[email protected]>

* Update HeaderFindAndReplaceCreator.cs: Split by char

* Review

* Fix 'length' value for 'Substring' 2nd param

* Add unit test to check replacements in the middle

---------

Co-authored-by: Raman Maksimchuk <[email protected]>
Co-authored-by: Raynald Messié <[email protected]>

* Adding a check for null downstreamResponse, plus tests.

* Target-typed new expressions

* Remove and Sort Usings

* Fix test

* Remove usings

---------

Co-authored-by: raman-m <[email protected]>

* Code refactoring and improvements

* Fix unit tests for ConsulServiceDiscoveryProvider

* Add default port

* Throw NullRef exception if no client

* Fix 'should_not_get' unit test

* Add AgentService extensions

* Use current naming conventions for unit tests

* Fix code smell with methos signature

* Encapsulate warning string creation.
Create expected value from a hardcoded string in unit tests

…ake' script (#1716)

* Rename Release Notes file

* Refactor the CreateReleaseNotes task

* Use Func delegate instead of static local function

* Add () after type  😆

* Delete ReleaseNotes.md

* Fix bug in parsing of output of "git shortlog" command

* Re-add release notes file

* Final version of CreateReleaseNotes task

* Fix build.cake warning SYSLIB0014: 'WebRequest.CreateHttp(string)' is obsolete.
Refactor GetResourceAsync private method

* Read main header from Git file

* Make CreateReleaseNotes task dependent on Version one
Make Release task dependent on CreateReleaseNotes one

* Add Done status for each task