Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs typo - Update requestaggregation.rst #1542

Closed
wants to merge 2 commits into from
Closed

Docs typo - Update requestaggregation.rst #1542

wants to merge 2 commits into from

Conversation

lf-novelt
Copy link

@lf-novelt lf-novelt commented Dec 15, 2021 •
edited
Loading

Proposed Changes

@lf-novelt lf-novelt changed the title Update requestaggregation.rst Docs typo - Update requestaggregation.rst Dec 15, 2021
@raman-m
Copy link
Member

raman-m commented May 16, 2023 •
edited
Loading

@lf-novelt
I am afraid that master branch is not in development process anymore... It was not updated in 2022 during 18.0.0 release.

Hi Louis!

So, requesting to master is wrong!
You can request PRs to develop branch only!

Please, change the base (target) branch!
I would recommend to pull latest commits from base:develop and please apply your changes on the top commit!

Pay attention that CI pipelines are working for main and develop branches only!
I have to check CI pipeline status also before starting code review...
Also, I have no right to change PR target/base branch. So, only PR author can change base branch of the PR!

@raman-m raman-m added invalid Not actually an issue documentation Needs a documentation update waiting Waiting for answer to question or feedback from issue raiser labels May 16, 2023
@raman-m raman-m marked this pull request as draft May 16, 2023 16:54
@lf-novelt lf-novelt changed the base branch from master to develop May 16, 2023 18:15
@lf-novelt lf-novelt marked this pull request as ready for review May 16, 2023 18:16
@raman-m
Copy link
Member

raman-m commented May 20, 2023

Hi!
Please, delete current fork.
Re-fork the repo, and create separate feature branches from develop for PRs! Do not change develop branch!

Sorry, this PR will be closed as invalid because of 2 parents in merge commit Merge branch 'develop' into patch-1 on the top!
You have to use rebase operation instead of classic merge commit.

@raman-m raman-m marked this pull request as draft May 20, 2023 18:22
@raman-m raman-m marked this pull request as ready for review July 10, 2023 18:54
@raman-m raman-m self-requested a review July 10, 2023 18:59
raman-m added a commit that referenced this pull request Jul 10, 2023
@raman-m
#1542 Update requestaggregation.rst
0d315db
@raman-m raman-m added accepted Bug or feature would be accepted as a PR or is being worked on and removed invalid Not actually an issue waiting Waiting for answer to question or feedback from issue raiser labels Jul 10, 2023
@raman-m
Copy link
Member

raman-m commented Jul 10, 2023

Duplicate of #1678

@raman-m raman-m marked this as a duplicate of #1678 Jul 10, 2023
@raman-m
Copy link
Member

raman-m commented Jul 10, 2023

@lf-novelt Louis Frament
Thanks for typo reporting!

@raman-m raman-m closed this Jul 10, 2023
raman-m added a commit that referenced this pull request Sep 23, 2023
@raman-m
#1542 Update requestaggregation.rst
163fa87
raman-m added a commit that referenced this pull request Sep 25, 2023
@raman-m
#1677 #1686 United documentation update (#1678)
75cd0b3 
* #1676 Update authorization.rst

* #1646 Update bigpicture.rst

* #1628 Update websockets.rst

* #1614 Update README.md

* #1552 Update configuration.rst

* #1547 Update caching.rst

* #1542 Update requestaggregation.rst

* Revert "#1639 Update ClientRateLimitMiddleware.cs"

This reverts commit 996719e.

* #1537 Update routing.rst

* #1520 Update authentication.rst

* #1459 Update building.rst

Fix inline code block

* #1412 Update errorcodes.rst

* #1407 Update headerstransformation.rst

* #1406 Update headerstransformation.rst

Remove extra '!'

* #1320 Update README.md

* Update README.md

Mark classes. Split sentences.

* #1284 Update claimstransformation.rst

* #1232 Update servicediscovery.rst

* #1224 Update loadbalancer.rst

* #1189 Update caching.rst

* Update gettingstarted.rst

Mark up 'net7.0' as code block. Convert script block to PowerShell one. Change the link to NuGet.

* #1386 Update loadbalancer.rst

* Update loadbalancer.rst: Make code snippet shorter

* #1686 Update middlewareinjection.rst

Add section "ASP.NET Core Middlewares and Ocelot Pipeline Builder"

* Update logging.rst

Review RST markup

* Update methodtransformation.rst

Review RST markup

* Update README.md

Sync to "Big Picture" page in Introduction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raman-m raman-m raman-m approved these changes

Assignees

@lf-novelt lf-novelt

Labels
accepted Bug or feature would be accepted as a PR or is being worked on documentation Needs a documentation update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lf-novelt @raman-m