Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update routing.rst #1537

Closed
wants to merge 2 commits into from
Closed

Update routing.rst #1537

wants to merge 2 commits into from

Conversation

abg98
Copy link

@abg98 abg98 commented Nov 15, 2021

nitpick grammatical error

@raman-m
Copy link
Member

raman-m commented May 18, 2023

Hi @abg98 !
I am afraid that master branch is not in development process anymore... It was not updated in 2022 during 18.0.0 release.

So, requesting to master is wrong!
You can request PRs to develop branch only!

Please, change the base (target) branch!
I would recommend to pull latest commits from base:develop and please apply your changes on the top commit via cherry pick git command!

Pay attention that CI pipelines are working for main and develop branches only!
I have to check CI pipeline status also before starting code review...
Also, I have no right to change PR target/base branch. So, only PR author can change base branch of the PR!

@raman-m raman-m added documentation Needs a documentation update waiting Waiting for answer to question or feedback from issue raiser labels May 18, 2023
@raman-m raman-m changed the base branch from master to develop May 20, 2023 10:14
@raman-m raman-m self-requested a review May 20, 2023 10:18
raman-m
raman-m previously approved these changes May 20, 2023
@raman-m raman-m added accepted Bug or feature would be accepted as a PR or is being worked on and removed waiting Waiting for answer to question or feedback from issue raiser labels May 20, 2023
@raman-m raman-m requested a review from TomPallister May 20, 2023 10:21
nitpick grammatical error
raman-m added a commit that referenced this pull request Jul 11, 2023
@raman-m
Copy link
Member

raman-m commented Jul 11, 2023

Duplicate of #1678

@raman-m raman-m marked this as a duplicate of #1678 Jul 11, 2023
@raman-m
Copy link
Member

raman-m commented Jul 11, 2023

Thanks for typo reporting!

@raman-m raman-m closed this Jul 11, 2023
@raman-m
Copy link
Member

raman-m commented Aug 9, 2023

Hi!
I don't see develop branch in your fork! Your fork is too old.

Could you Sync fork please? So, new develop branch will occur with all top commits!


If Sync fork button won't help to make develop branch as default one,
Run this script please:

git remote add upstream https://github.com/ThreeMammals/Ocelot.git # add original repo as upstream remote

git remote add upstream [email protected]:ThreeMammals/Ocelot.git     # add original repo via SSH
git fetch upstream                                                 # pull changes from original repo
git checkout -b develop upstream/develop                           # pull down develop branch locally
git push -u origin develop                                         # push develop branch to fork

Don't forget to make develop as default branch in GitHub.
Let me know updating results please!


I don't see develop branch in your fork! Your fork is too old.

Could you Sync fork please? So, new develop branch will occur with all top commits!

Could you add me as collaborator to your forked repo please? I will create develop branch and make it default.

raman-m added a commit that referenced this pull request Sep 23, 2023
raman-m added a commit that referenced this pull request Sep 25, 2023
* #1676 Update authorization.rst

* #1646 Update bigpicture.rst

* #1628 Update websockets.rst

* #1614 Update README.md

* #1552 Update configuration.rst

* #1547 Update caching.rst

* #1542 Update requestaggregation.rst

* Revert "#1639 Update ClientRateLimitMiddleware.cs"

This reverts commit 996719e.

* #1537 Update routing.rst

* #1520 Update authentication.rst

* #1459 Update building.rst

Fix inline code block

* #1412 Update errorcodes.rst

* #1407 Update headerstransformation.rst

* #1406 Update headerstransformation.rst

Remove extra '!'

* #1320 Update README.md

* Update README.md

Mark classes. Split sentences.

* #1284 Update claimstransformation.rst

* #1232 Update servicediscovery.rst

* #1224 Update loadbalancer.rst

* #1189 Update caching.rst

* Update gettingstarted.rst

Mark up 'net7.0' as code block. Convert script block to PowerShell one. Change the link to NuGet.

* #1386 Update loadbalancer.rst

* Update loadbalancer.rst: Make code snippet shorter

* #1686 Update middlewareinjection.rst

Add section "ASP.NET Core Middlewares and Ocelot Pipeline Builder"

* Update logging.rst

Review RST markup

* Update methodtransformation.rst

Review RST markup

* Update README.md

Sync to "Big Picture" page in Introduction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Bug or feature would be accepted as a PR or is being worked on documentation Needs a documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants