Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect port number #1628

Closed
wants to merge 2 commits into from
Closed

Incorrect port number #1628

wants to merge 2 commits into from

Conversation

onurkanbakirci
Copy link

@onurkanbakirci onurkanbakirci commented Dec 24, 2022 •
edited
Loading

In websocket config docs, port number have to be 5001 as described in text explanation instead of 50000.

@raman-m raman-m self-requested a review May 5, 2023 13:22
@raman-m
Copy link
Member

raman-m commented May 5, 2023

In websocket config docs, port number have to be 5001 as described in text explanation instead of 50000.

Hi Onurkan!
Yes, you are right, ports do not match now in SignalR paragraph.
But it is still not clear: should it be 5001 or 50000 actually?
Let's ask Tom, and he will decide.

@raman-m raman-m requested a review from TomPallister May 5, 2023 13:45
@onurkanbakirci
Copy link
Author

Hi @raman-m .
It should be 5001

@raman-m raman-m added the documentation Needs a documentation update label May 7, 2023
@raman-m raman-m added accepted Bug or feature would be accepted as a PR or is being worked on in progress Someone is working on the issue. Could be someone on the team or off. labels May 16, 2023
@raman-m raman-m removed the in progress Someone is working on the issue. Could be someone on the team or off. label Jun 3, 2023
@onurkanbakirci @raman-m
Incorrect port number
8e5f632 
In websocket config docs, port number have to be `5000` as described in text explanation instead of `50000`.
@onurkanbakirci @raman-m
bug fixes
1a0b4bf
raman-m added a commit that referenced this pull request Jul 10, 2023
@raman-m
#1628 Update websockets.rst
461ba4c
@raman-m
Copy link
Member

raman-m commented Jul 10, 2023 •
edited
Loading

@onurkanbakirci
Thank you, Onurkan Bakırcı!

@raman-m raman-m closed this Jul 10, 2023
@raman-m
Copy link
Member

raman-m commented Jul 10, 2023

Duplicate of #1678

@raman-m raman-m marked this as a duplicate of #1678 Jul 10, 2023
raman-m added a commit that referenced this pull request Sep 23, 2023
@raman-m
#1628 Update websockets.rst
3323db4
raman-m added a commit that referenced this pull request Sep 25, 2023
@raman-m
#1677 #1686 United documentation update (#1678)
75cd0b3 
* #1676 Update authorization.rst

* #1646 Update bigpicture.rst

* #1628 Update websockets.rst

* #1614 Update README.md

* #1552 Update configuration.rst

* #1547 Update caching.rst

* #1542 Update requestaggregation.rst

* Revert "#1639 Update ClientRateLimitMiddleware.cs"

This reverts commit 996719e.

* #1537 Update routing.rst

* #1520 Update authentication.rst

* #1459 Update building.rst

Fix inline code block

* #1412 Update errorcodes.rst

* #1407 Update headerstransformation.rst

* #1406 Update headerstransformation.rst

Remove extra '!'

* #1320 Update README.md

* Update README.md

Mark classes. Split sentences.

* #1284 Update claimstransformation.rst

* #1232 Update servicediscovery.rst

* #1224 Update loadbalancer.rst

* #1189 Update caching.rst

* Update gettingstarted.rst

Mark up 'net7.0' as code block. Convert script block to PowerShell one. Change the link to NuGet.

* #1386 Update loadbalancer.rst

* Update loadbalancer.rst: Make code snippet shorter

* #1686 Update middlewareinjection.rst

Add section "ASP.NET Core Middlewares and Ocelot Pipeline Builder"

* Update logging.rst

Review RST markup

* Update methodtransformation.rst

Review RST markup

* Update README.md

Sync to "Big Picture" page in Introduction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raman-m raman-m raman-m approved these changes

@TomPallister TomPallister Awaiting requested review from TomPallister

Assignees

@onurkanbakirci onurkanbakirci

Labels
accepted Bug or feature would be accepted as a PR or is being worked on documentation Needs a documentation update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onurkanbakirci @raman-m