Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in caching documentation #1547

Closed
wants to merge 1 commit into from
Closed

Fix typo in caching documentation #1547

wants to merge 1 commit into from

Conversation

baseballpluto
Copy link

Fix typo in caching.rst file

stefancruz pushed a commit to stefancruz/Ocelot that referenced this pull request Dec 22, 2022
@raman-m
Copy link
Member

raman-m commented May 13, 2023

Hi Michael!

Requesting to master is wrong!
You can request PRs to develop branch only!

Please, change the base (target) branch!
I would recommend to pull latest commits from base:develop and apply your changes on the top commit!

In develop branch we still have the issue: caching.rst

@raman-m raman-m added invalid Not actually an issue documentation Needs a documentation update labels May 13, 2023
@raman-m raman-m marked this pull request as draft May 13, 2023 14:10
@raman-m raman-m changed the base branch from master to develop May 20, 2023 18:11
raman-m added a commit that referenced this pull request Jul 10, 2023
@raman-m raman-m marked this pull request as ready for review July 10, 2023 18:48
@raman-m
Copy link
Member

raman-m commented Jul 10, 2023

Duplicate of #1678

@raman-m raman-m marked this as a duplicate of #1678 Jul 10, 2023
@raman-m
Copy link
Member

raman-m commented Jul 10, 2023

@michaelmoore04 Michael Moore
Thanks for typo reporting!

@raman-m raman-m closed this Jul 10, 2023
raman-m added a commit that referenced this pull request Sep 23, 2023
raman-m added a commit that referenced this pull request Sep 25, 2023
* #1676 Update authorization.rst

* #1646 Update bigpicture.rst

* #1628 Update websockets.rst

* #1614 Update README.md

* #1552 Update configuration.rst

* #1547 Update caching.rst

* #1542 Update requestaggregation.rst

* Revert "#1639 Update ClientRateLimitMiddleware.cs"

This reverts commit 996719e.

* #1537 Update routing.rst

* #1520 Update authentication.rst

* #1459 Update building.rst

Fix inline code block

* #1412 Update errorcodes.rst

* #1407 Update headerstransformation.rst

* #1406 Update headerstransformation.rst

Remove extra '!'

* #1320 Update README.md

* Update README.md

Mark classes. Split sentences.

* #1284 Update claimstransformation.rst

* #1232 Update servicediscovery.rst

* #1224 Update loadbalancer.rst

* #1189 Update caching.rst

* Update gettingstarted.rst

Mark up 'net7.0' as code block. Convert script block to PowerShell one. Change the link to NuGet.

* #1386 Update loadbalancer.rst

* Update loadbalancer.rst: Make code snippet shorter

* #1686 Update middlewareinjection.rst

Add section "ASP.NET Core Middlewares and Ocelot Pipeline Builder"

* Update logging.rst

Review RST markup

* Update methodtransformation.rst

Review RST markup

* Update README.md

Sync to "Big Picture" page in Introduction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Needs a documentation update invalid Not actually an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants