Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding typechecks to Column Operations #6298

Merged
merged 9 commits into from
Apr 21, 2023
Merged

Adding typechecks to Column Operations #6298

merged 9 commits into from
Apr 21, 2023

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Apr 15, 2023 •
edited
Loading

Pull Request Description

Closes #6106

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 15, 2023
@radeusgd radeusgd self-assigned this Apr 15, 2023
@radeusgd radeusgd force-pushed the wip/radeusgd/column-typechecks-6106 branch 2 times, most recently from 8fda1a0 to 61b013c Compare April 18, 2023 09:32
@radeusgd radeusgd mentioned this pull request Apr 18, 2023
Closed
@radeusgd radeusgd force-pushed the wip/radeusgd/column-typechecks-6106 branch from 2369ff2 to ddb7f67 Compare April 19, 2023 12:58
@radeusgd radeusgd added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Apr 19, 2023
@radeusgd radeusgd marked this pull request as ready for review April 19, 2023 14:57
@radeusgd radeusgd force-pushed the wip/radeusgd/column-typechecks-6106 branch from 1c294ce to 09f9df2 Compare April 19, 2023 22:43
jdunkerley
jdunkerley reviewed Apr 20, 2023
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Through quite a lot of the files... will finish review shortly but here are a few comments!

distribution/lib/Standard/Database/0.0.0-dev/src/Internal/Database_Type_Helpers.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Errors.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Errors.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Errors.enso
- types: The types that were tried to be unified.
- related_column_name: The name of the resulting column that was being
unified, if applicable.
Error (types : Vector Value_Type) (related_column_name : Nothing|Text)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we default related_column_name to Nothing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it could be better to keep it required and specify Nothing explicitly. Otherwise, with other errors like that I was sometimes not adding the related column, because it was optional and I was simply forgetting it is supposed to be there. Whereas, if it's a required argument it forces to think if we can 'put something' there.

distribution/lib/Standard/Database/0.0.0-dev/src/Internal/Statement_Setter.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Data/Type/Value_Type.enso Outdated Show resolved Hide resolved
test/Table_Tests/src/In_Memory/Table_Spec.enso Show resolved Hide resolved
@radeusgd radeusgd force-pushed the wip/radeusgd/column-typechecks-6106 branch 2 times, most recently from 7c7b4b3 to fdbf5e3 Compare April 20, 2023 15:05
jdunkerley
jdunkerley approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One slight change please.

Looks really good and great range of test coverage.

distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Column.enso Outdated Show resolved Hide resolved
@radeusgd radeusgd force-pushed the wip/radeusgd/column-typechecks-6106 branch from fdbf5e3 to 2bf87d2 Compare April 21, 2023 11:15
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Apr 21, 2023
@radeusgd radeusgd mentioned this pull request Apr 21, 2023
Merged
5 tasks
@mergify mergify bot merged commit 8db2ad5 into develop Apr 21, 2023
@mergify mergify bot deleted the wip/radeusgd/column-typechecks-6106 branch April 21, 2023 12:20
mergify bot pushed a commit that referenced this pull request Apr 24, 2023
@radeusgd
Add typechecks to Aggregate and Cross Tab (#6380)
a43d524 
Follow up of #6298 as it grew too much. Adds the needed typechecks to aggregate operations. Ensures that the DB operations report `Floating_Point_Equality` warning consistently with in-memory.
Procrat added a commit that referenced this pull request Apr 25, 2023
@Procrat
Merge branch 'develop' into wip/procrat/rename-project-with-space-5065
04b228f 
* develop:
  Turn null into UnexpectedExpression when Union type is incomplete (#6415)
  Ensure that IO.println does not fail if `to_text` returned a non-Text value. (#6223)
  Improve inlining of `<|` on (GraalVM EE) (#6384)
  Feat: update templates styles and feature (#6071)
  5127 Add Table.parse_to_columns to parse a single column to a set of columns. (#6383)
  URL handling (#6243)
  Exclude comparison operators from modifier logic (#6370)
  Better cleanup of project management test suite (#6392)
  Fix all eslint errors (#6267)
  Infer SQLite types locally (#6381)
  Vector Editor with List Editor and adding elements. (#6363)
  Add typechecks to Aggregate and Cross Tab (#6380)
  Forbid edits in read-only mode (#6342)
  Add Table.parse_text_to_table to convert Text to a Table. (#6294)
  Adding typechecks to Column Operations (#6298)
  Rollback cloud options groups (#6331)
  Project folder not renamed after project name change (#6369)
  Add `replace`, `trim` to Column. Better number parsing. (#6253)
  Read-only mode for controllers (#6259)
  Prevent default for all events, fixing multiple IDE bugs (#6364)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

Assignees

@radeusgd radeusgd

Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing type-checks to column operations
3 participants
@radeusgd @jdunkerley @GregoryTravis